Skip to content

Prefere .bookignore when build too #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

podsvirov
Copy link

@podsvirov podsvirov commented Oct 16, 2022

Reuse watch command experience (#1044) and process .bookignore (as .gitignore) if prezent.

MOTIVATION: I'm just type src = "." in book.toml and understand that something is wrong...

SOLUTION: I'm make this PR and add .bookignore file and life is good, because mdbook build no more copy target to book! :-)

podsvirov added a commit to podsvirov/mdbook-pikchr that referenced this pull request Oct 16, 2022
@brettchalupa
Copy link
Contributor

These efforts seem similar to #1908, which is adding support for an .mdbookignore file option too.

@podsvirov
Copy link
Author

My solution is very small and not change any dependencies, but looks like the ignore crate more popular and use it will add some improvements.

I'm fine with any solution that allows to filter files at build time.

Reuse watch command experience and process .bookignore (as .gitignore) if prezent.
@ehuss ehuss added the A-ignore Area: gitignore, ignoring files label Feb 25, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2025

☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ignore Area: gitignore, ignoring files S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants