Basic swipe gesture functionality for opening/closing sidebar #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried this out on both my laptop (using chrome dev tools) and mobile. I think the thresholds are slightly off, but it's hard to pinpoint exactly what feels odd about them when experimenting on a mobile. I think this should be good to merge, if we need to we can always come back and tweak the thresholds anyway. |
This was referenced Jan 2, 2018
Closed
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Basic swipe gesture functionality for opening/closing sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #274. Not 100% certain about the thresholds or details of the behavior, but it seems intuitive enough to me. Suggestions are appreciated, however.
Recommended merging #470 (or similar) first. Otherwise, swiping will also scroll the page on smaller screens due to overflowing content.