Skip to content

Failing integrity tests #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matklad opened this issue Apr 23, 2020 · 1 comment · Fixed by #4139
Closed

Failing integrity tests #4103

matklad opened this issue Apr 23, 2020 · 1 comment · Fixed by #4139
Labels
A-macro macro expansion E-unknown It's unclear if the issue is E-hard or E-easy without digging in

Comments

@matklad
Copy link
Member

matklad commented Apr 23, 2020

Some tests from rust test suite where we die:

  • /ui/issues/issue-57597.rs macros
  • ui/empty/empty-comment.rs macros
@matklad
Copy link
Member Author

matklad commented Apr 23, 2020

Actually, I think these are the only tests from ui test suite where we fail.

cc @edwin0cheng

@matklad matklad added the E-unknown It's unclear if the issue is E-hard or E-easy without digging in label Apr 23, 2020
@edwin0cheng edwin0cheng added the A-macro macro expansion label Apr 23, 2020
@edwin0cheng edwin0cheng mentioned this issue Apr 25, 2020
Merged
bors bot added a commit that referenced this issue Apr 25, 2020
@bors @edwin0cheng
Merge #4134
487baae 
4134: Special case for empty comments in doc comment kind  r=matklad a=edwin0cheng

Part of #4103

Fix `ui/empty/empty-comment.rs macros`

Co-authored-by: Edwin Cheng <[email protected]>
bors bot added a commit that referenced this issue Apr 25, 2020
@bors @edwin0cheng
Merge #4134
7bc7173 
4134: Special case for empty comments in doc comment kind  r=matklad a=edwin0cheng

Part of #4103

Fix `ui/empty/empty-comment.rs macros`

Co-authored-by: Edwin Cheng <[email protected]>
@edwin0cheng edwin0cheng mentioned this issue Apr 25, 2020
Merged
@bors bors bot closed this as completed in 5671bac Apr 25, 2020
@bors bors bot closed this as completed in #4139 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macro macro expansion E-unknown It's unclear if the issue is E-hard or E-easy without digging in
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check for rules that no repetition which could match an empty token edwin0cheng/rust-analyzer
2 participants
@matklad @edwin0cheng