Skip to content

Add check for rules that no repetition which could match an empty token #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

Add check for rules that no repetition which could match an empty token #4139

merged 1 commit into from
Apr 25, 2020

Conversation

edwin0cheng
Copy link
Member

@edwin0cheng edwin0cheng commented Apr 25, 2020 •
edited
Loading

Fix #4103

for /ui/issues/issue-57597.rs

This is ParseError of the macro rules , because it is how rustc handle it :

https://github.com/rust-lang/rust/blob/a58b1ed44f5e06976de2bdc4d7dc81c36a96934f/src/librustc_expand/mbe/macro_rules.rs#L558

@edwin0cheng edwin0cheng force-pushed the fix-rustc-issue-57597 branch from ff7cf10 to d5eb43f Compare April 25, 2020 15:30
@matklad
Copy link
Member

matklad commented Apr 25, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 25, 2020

Build succeeded:

@bors bors bot merged commit 5671bac into rust-lang:master Apr 25, 2020
@edwin0cheng edwin0cheng deleted the fix-rustc-issue-57597 branch April 26, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing integrity tests
2 participants
@edwin0cheng @matklad