Make inlay hints work in attributed items #10231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ magical ✨ |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2021
10240: internal: Revert attributed items inlay hints r=Veykril a=Veykril Reverts #10231 as the implementation there is actually wrong bors r+ Co-authored-by: Lukas Wirth <[email protected]>
Veykril
changed the title
Veykril
changed the title
Veykril
changed the title
Veykril
changed the title
|
changelog skip |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2021
10274: feat: Make inlay hints work in attributed items r=Veykril a=Veykril Attempt at #10043(previous attempt #10231)  Slight difference to the first approach, chaining hints now work but attribute inputs do not as they are basically the same as normal macros in that they take a token tree. Fixes #10043 Co-authored-by: Lukas Wirth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the lack of chaining hints, this is currently due to macro expansion lacking the input whitespace. We might be able to recover this from the input somehow in the future.Fixes #10043
bors r+