Skip to content

feat: Make inlay hints work in some attributed items #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 18, 2021

Second attempt at #10043(previous attempt #10231), still doesn't seem to work in every case...
image
Slight difference to the first approach, chaining hints now work but attribute inputs do not as they are basically the same as normal macros in that they take a token tree.

Fixes #10043

@Veykril
Copy link
Member Author

Veykril commented Sep 18, 2021

Well that's odd, the test passes but it doesn't work 🤔
Turns out you gotta make sure you are running the right server binary...

@Veykril
Copy link
Member Author

Veykril commented Sep 18, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 18, 2021

@bors bors bot merged commit ba16c16 into rust-lang:master Sep 18, 2021
@Veykril Veykril deleted the inlay-hints-attr branch September 18, 2021 11:52
@Veykril Veykril changed the title feat: Make inlay hints work in attributed items feat: Make inlay hints work in some attributed items Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlay hints should work in attributed items with bodies
1 participant