MIR episode 6 #14892
Merged
MIR episode 6 #14892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
HKalbasi
force-pushed
the
mir
branch
2 times, most recently
from
cf9c8ac to
2812814
Compare
Veykril
reviewed
May 25, 2023
HKalbasi
force-pushed
the
mir
branch
3 times, most recently
from
cdf5253 to
11c91da
Compare
|
☔ The latest upstream changes (presumably #14904) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Veykril
reviewed
Jun 1, 2023
| /// } | ||
| /// } | ||
| /// ``` | ||
| fn collect_for_loop(&mut self, syntax_ptr: AstPtr<ast::Expr>, e: ast::ForExpr) -> ExprId { |
There was a problem hiding this comment.
The lowering broke our label resolution it seems, I'm spotting a bunch of undeclared label diagnostics in r-a
bors
added a commit
that referenced
this pull request
Jun 1, 2023
fix bug in labeled for loop desugaring fix #14892 (comment)
|
any more episodes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates monomorphization from interpreting, and add a monomorphization query to cache the results. Together with making layout queries returning
Arc<Layout>instead ofLayout(did you know thatLayoutis a 312 byte struct with a couple of vectors, so it is very costly to clone? I thought it should be very small and cheap) it makes mir interpreting an order of magnitude faster in warmed calls.It still can't evaluate no test in the r-a repo, but all tests that I tried are hitting #7434 so I hope after that it will become able to interpret some real world test.