fix: Render size, align and offset hover values in hex #14904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
We could make this configurable if really desired, but I'll merge this for now. |
|
☀️ Test successful - checks-actions |
Merged
|
Might be nice to only do this for numbers >= 16 or so, but doesn't matter too much. |
lnicola
changed the title
|
This is very annoying. Please make it a toggle. A struct being 0x1B0 bytes in size is meaningless. |
|
Tracked in #14918. |
|
I would like to have the option to go back to viewing it as plain decimal. Hexadecimal is great for memory operations, but doesn't really help my monkey brain when I'm trying to look at the computed size of a struct with lots of other complex fields to see the actual memory footprint. Perhaps an option like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably, these values are usually almost always viewed in hex format so I think we should do the same here