Add unstable cargo lint tables and make use of clippy #15017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Turns out the autofix command doesn't really work that well with lint tables, so fixing by hand it is |
|
Okay, so this is a ton of changes obviously, will take another look at the diff myself later to see if there are any changes here that we aren't too fond of after all (and then add exceptions for it). |
|
I cant repro the panic locally on windows 😕 |
Veykril
force-pushed
the
clippy
branch
3 times, most recently
from
264301c to
dd07ebf
Compare
|
@bors try |
bors
added a commit
that referenced
this pull request
Jun 10, 2023
Add unstable cargo lint tables and make use of clippy Figured we can allow all lints and then selectively disable the ones we don't want. The nice thing is this doesn't break stable builds, although it does spam a bit for each cargo toml ...
|
☀️ Try build successful - checks-actions |
Urhengulas
added a commit
to Urhengulas/rust-analyzer
that referenced
this pull request
Jan 19, 2024
3 tasks
bors
added a commit
that referenced
this pull request
Jan 19, 2024
Expand lint tables && make clippy happy 🎉 This PR expands the lint tables on `./Cargo.toml` and thereby makes `cargo clippy` exit successfully! 🎉 Fixes #15918 ## How? In the beginning there are some warnings for rustc. Next, and most importantly, there is the clippy lint table. There are a few sections in there. First there are the lint groups. Second there are all lints which are permanently allowed with the reasoning why they are allowed. Third there is a huge list of temporarily allowed lints. They should be removed in the mid-term, but incur a substantial amount of work, therefore they are allowed for now and can be worked on bit by bit. Fourth there are all lints which should warn. Additionally there are a few allow statements in the code for lints which should be permanently allowed in this specific place, but not in the whole code base. ## Follow up work - [ ] Run clippy in CI - [ ] Remove tidy test (at least `@Veykril` wrote this in #15017) - [ ] Work on temporarily allowed lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured we can allow all lints and then selectively disable the ones we don't want. The nice thing is this doesn't break stable builds, although it does spam a bit for each cargo toml ...