internal: Expand lint tables && make clippy happy 🎉 #16401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will be removed one by one
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jan 19, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 19, 2024
Work through temporarily allowed clippy lints, part 1 This is the first batch of not allowing but actually fixing the clippy lints. Each commit removes one lint from the lint table and then fixes the resulting warnings. Follow-up to #16401
lnicola
changed the title
bors
added a commit
that referenced
this pull request
Jan 30, 2024
internal: Add `clippy` to CI Follow-up to #16401
bors
added a commit
that referenced
this pull request
Jan 31, 2024
internal: Work through temporarily allowed clippy lints, part 2 Another follow-up to #16401.
bors
added a commit
that referenced
this pull request
Feb 1, 2024
internal: Work through temporarily allowed clippy lints, part 2 Another follow-up to #16401.
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the lint tables on
./Cargo.tomland thereby makescargo clippyexit successfully! 🎉Fixes #15918
How?
In the beginning there are some warnings for rustc.
Next, and most importantly, there is the clippy lint table. There are a few sections in there.
First there are the lint groups.
Second there are all lints which are permanently allowed with the reasoning why they are allowed.
Third there is a huge list of temporarily allowed lints. They should be removed in the mid-term, but incur a substantial amount of work, therefore they are allowed for now and can be worked on bit by bit.
Fourth there are all lints which should warn.
Additionally there are a few allow statements in the code for lints which should be permanently allowed in this specific place, but not in the whole code base.
Follow up work