fix: Fix diagnostics not clearing between flychecks #18864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jan 7, 2025
| self.clear_diagnostics_state(); | ||
| } | ||
|
|
||
| fn clear_diagnostics_state(&mut self) { |
There was a problem hiding this comment.
👍 we should've done this from the start
|
Nevermind, you answered just after I posted 😁 |
|
Thanks! |
|
This is now available in the v0.3.2257 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #18848 fixed an issue with diagnostics clearing too eagerly, and 140f91b fixed an issue with diagnostics state not being properly reset between flychecks, we're still facing an issue where diagnostics are not cleared at all between flychecks runs.
Indeed, if the diagnostic doesn't have a corresponding package_id (as is the case with rustc diagnostics), it won't get cleared between flychecks.
This diff adds a
diagnostics_cleared_for_allflag to keep track of such diagnostics, and moves the diagnostics state clearing to its own method.