Minor refactor format-impls #12274
Merged
Minor refactor format-impls #12274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move all linting logic into a single format implementations struct This should help with the future format-args improvements. TODO: do the same with format_args.rs, perhaps in the same PR
rustbot
added
the
S-waiting-on-review
xFrednet
approved these changes
Feb 11, 2024
|
LGTM, nice refactoring!
This PR is large enough to be merged. If you want to do that change, you can |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
bors
added a commit
that referenced
this pull request
Feb 12, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all linting logic into a single format implementations struct
This should help with the future format-args improvements.
TODO: do the same with format_args.rs, perhaps in the same PR
NOTE TO REVIEWERS: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified.
changelog: none