Minor refactor format-args #12283
Minor refactor format-args #12283
Conversation
* Move all linting logic into a single format implementations struct This should help with the future format-args improvements.
rustbot
added
the
S-waiting-on-review
nyurik
force-pushed
the
ref-format-args
branch
from
c6ed2ad to
2c3ae88
Compare
|
Looks good to me, thank you for also refactoring this implementation :D @bors r+ |
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
|
💔 Test failed - checks-action_test |
|
Bors is currently flaky... @bors retry |
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
|
💔 Test failed - checks-action_test |
|
Bors please! 🙏 @bors retry |
|
I'll also give you the rights to retry (Because spaming will surely fix it ^^) @bors d+ |
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
|
Perhaps we need another bot to auto-retry? let them fight it out? |
|
💔 Test failed - checks-action_test |
|
I wield magic power of thee, obey me @bors retry |
|
@nyurik: 🔑 Insufficient privileges: not in try users |
|
as always, robots have more power over me :( Help us @xFrednet , you are our only hope... |
|
@bors retry |
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from #12274 r? `@xFrednet` --- changelog: none
|
💔 Test failed - checks-action_test |
|
Usually it works after the third retry, maybe let's just wait a bit. I'll retry it tomorrow |
|
thanks! I'll try it a bit later too... just for the fun of it :) |
|
@bors retry , and i won't muck you again! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
see! you had to be nice to bors ;) |
This should help with the future format-args improvements.
NOTE TO REVIEWERS: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified.
Followig up from #12274
r? @xFrednet
changelog: none