Skip to content

Soft rename clippy::all to clippy::default #14689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Soft rename clippy::all to clippy::default #14689

wants to merge 1 commit into from

Conversation

Alexendoo
Copy link
Member

r? @flip1995

For now I haven't updated the docs since people read the current README/etc for stable usage

changelog: clippy::all has been renamed to clippy::default, existing uses of clippy::all do not need to be changed

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 24, 2025
smoelius
smoelius reviewed Apr 24, 2025
View reviewed changes
tests/ui/clippy_all_group.rs
@@ -0,0 +1,11 @@
// Tests that `clippy::all` still works without a deprecation warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to intrude, but why don't you want a deprecation warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's starting as a soft deprecation since it's very widely used, it may eventually become a warning

Copy link
Member

@flip1995 flip1995 Apr 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not deprecate it. I don't think it is ever worth to do so. I think clippy::all is older than 5 years by now. It will take at least the same amount of time until clippy::default is used in more places than clippy::all, I would think. So maybe really really long-term, we can deprecate it. But that might even be the decision of a different set of people by then.

Plus, I don't see any downsides in keeping it.

flip1995
flip1995 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Giving @rust-lang/clippy @rust-lang/clippy-contributors until the end of the week to still raise concerns (as there's no going back realistically). But I think everyone is on-board with this.

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

☔ The latest upstream changes (possibly #14896) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

+1 more reviewer

@smoelius smoelius smoelius left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexendoo @rustbot @flip1995 @smoelius