Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 25, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 25, 2025
@Jarcho Jarcho force-pushed the dev_sorted_lints branch from 1be0a11 to 2c1682b Compare May 25, 2025 19:09
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of a failure in cargo dev lint is changed for the worse.

Also, the commit message first line of the first commit is a bit too long and gets wrapped into the detailed description.

@Jarcho Jarcho force-pushed the dev_sorted_lints branch from 2c1682b to 7f8dfc4 Compare June 19, 2025 01:51
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Good to merge after addressing the merge conflict @Jarcho (and also, apologies for the delay in reviewing).

@Jarcho Jarcho force-pushed the dev_sorted_lints branch from 7f8dfc4 to 303ac66 Compare July 9, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants