fix(manual_assert): use multipart suggestion instead of simple span_suggestion #15226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…suggestion This resolves rust-lang#13099 by converting the suggestion into a multipart suggestion, allowing rustfix to apply it correctly.
rustbot
added
the
S-waiting-on-review
Knotty123230
changed the title
dswij
requested changes
Jul 14, 2025
rustbot
added
S-waiting-on-author
ada4a
reviewed
Aug 3, 2025
| LL + multiline | ||
| LL + comment */ | ||
| LL + /// Doc comment | ||
| LL + // comment after `panic!` |
There was a problem hiding this comment.
shouldn't this comment have stayed after panic!, now assert!?
|
☔ The latest upstream changes (possibly #14896) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
manual_assertlint to usemultipart_suggestioninstead of a singlespan_suggestion.This change allows Clippy to properly apply suggestions when comments are present before or around the
if-then-panic!block. It removes the@no-rustfixannotation in the corresponding UI test and updates the.stderrfile accordingly.Fixes: #13099
changelog: fix manual_assert lint suggestion format