Skip to content

Fix two missing_const_for_fn false positives #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2019
Merged

Fix two missing_const_for_fn false positives #3844

merged 2 commits into from
Mar 5, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Mar 4, 2019 •
edited
Loading

Fixes #3841

  • Fixes false positive in external macros
  • Fixes false positive in impl trait methods

@phansch
Don't trigger missing_const_for_fn in external macros
b87f5bc 
As reported in rust-lang#3841. Only fixes the part where it triggers on the
`derive`.
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 4, 2019
@phansch phansch changed the title Don't trigger missing_const_for_fn in external macros Fix two missing_const_for_fn false positives Mar 5, 2019
oli-obk
oli-obk reviewed Mar 5, 2019
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Mar 5, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2019

📌 Commit 15cba2e has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Mar 5, 2019

⌛ Testing commit 15cba2e with merge a8f61e7...

bors added a commit that referenced this pull request Mar 5, 2019
@bors
Auto merge of #3844 - phansch:const_fn_external_macro, r=oli-obk
a8f61e7 
Fix two missing_const_for_fn false positives

Fixes #3841

* Fixes false positive in external macros
* Fixes false positive when implement trait methods
@bors
Copy link
Contributor

bors commented Mar 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing a8f61e7 to master...

@bors bors merged commit 15cba2e into rust-lang:master Mar 5, 2019
@phansch phansch deleted the const_fn_external_macro branch March 5, 2019 11:57
@phansch phansch mentioned this pull request Mar 7, 2019
Merged
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Mar 9, 2019
@flip1995
Rollup merge of rust-lang#3851 - phansch:refactor_trait_stuff, r=flip…
1902384 
…1995

Refactor: Extract `trait_ref_of_method` function

This pattern was used in three places after rust-lang#3844, so I think it's worth moving it into `utils/mod.rs` and documenting it.
@jhpratt
Copy link
Member

jhpratt commented Apr 17, 2019

@phansch Any timeline for this fix to go live? Running rustup component add clippy followed by cargo clippy --version gives 2019-03-03 (0.0.212) — before this patch was applied.

@phansch
Copy link
Member Author

phansch commented Apr 17, 2019

@jhpratt It's currently included in Rusts beta channel and should hit stable with Rust 1.35 on May 23rd. (It's unlikely that it will be included in a possible 1.34.1 release as it's a disabled-by-default lint)

@jhpratt
Copy link
Member

jhpratt commented Apr 17, 2019

It's not available on nightly beforehand? I guess that's where my confusion is at.

@phansch
Copy link
Member Author

phansch commented Apr 17, 2019

Oh I misunderstood the Clippy version. It should be available in nightly after nightly-2019-03-12.

@Manishearth Manishearth mentioned this pull request Apr 19, 2019
Merged
@pietroalbini pietroalbini mentioned this pull request Apr 23, 2019
Merged
bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
3ea00c5 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
89a3797 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
fc50f32 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 9, 2019
@he32
Update rust to version 1.34.1.
0f20f43 
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 19, 2019
@he32
Update rust to version 1.34.1.
69be0c3 
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@oli-obk oli-obk oli-obk left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trait functions cannot be const
4 participants
@phansch @oli-obk @bors @jhpratt