Skip to content

Refactor: Extract trait_ref_of_method function #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2019
Merged

Refactor: Extract trait_ref_of_method function #3851

merged 4 commits into from
Mar 9, 2019

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Mar 7, 2019 •
edited
Loading

This pattern was used in three places after #3844, so I think it's worth moving it into utils/mod.rs and documenting it.

@phansch phansch force-pushed the refactor_trait_stuff branch from 60e6b70 to a6b082c Compare March 7, 2019 06:51
@phansch phansch force-pushed the refactor_trait_stuff branch from a6b082c to e1d47cd Compare March 7, 2019 07:17
@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 7, 2019
flip1995
flip1995 reviewed Mar 8, 2019
View reviewed changes
@phansch phansch force-pushed the refactor_trait_stuff branch from f84b34a to 131b89b Compare March 8, 2019 08:43
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 8, 2019
@flip1995
Copy link
Member

flip1995 commented Mar 9, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2019

📌 Commit 131b89b has been approved by flip1995

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Mar 9, 2019
@flip1995
Rollup merge of rust-lang#3851 - phansch:refactor_trait_stuff, r=flip…
1902384 
…1995

Refactor: Extract `trait_ref_of_method` function

This pattern was used in three places after rust-lang#3844, so I think it's worth moving it into `utils/mod.rs` and documenting it.
@flip1995 flip1995 mentioned this pull request Mar 9, 2019
Merged
bors added a commit that referenced this pull request Mar 9, 2019
@bors
Auto merge of #3861 - flip1995:rollup, r=flip1995
8213d25 
Rollup of 3 pull requests

Successful merges:

 - #3851 (Refactor: Extract `trait_ref_of_method` function)
 - #3852 (Refactor: Cleanup one part of assign_ops lint)
 - #3857 (Document match_path, improve match_qpath docs)

Failed merges:

r? @ghost
@bors bors merged commit 131b89b into rust-lang:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansch @flip1995 @bors