Skip to content

Warnings in quoted & spliced code are buggy #18216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kmcallister opened this issue Oct 21, 2014 · 3 comments
Closed

Warnings in quoted & spliced code are buggy #18216

kmcallister opened this issue Oct 21, 2014 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-syntaxext Area: Syntax extensions I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@kmcallister
Copy link
Contributor

I'm not sure exactly what's going on but, for example, we missed some deprecation warnings in html5ever, which has #![deny(warnings)]. I've also seen ICEs in the past.
@kmcallister kmcallister added I-wrong A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-syntaxext Area: Syntax extensions A-diagnostics Area: Messages for errors, warnings, and lints I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ labels Oct 21, 2014
@steveklabnik
Copy link
Member

Is this bug still relevant?

@kmcallister
Copy link
Contributor Author

I believe so, but I don't have clear steps to reproduce :/

@tamird
Copy link
Contributor

tamird commented Apr 21, 2015

Looks like this is not actionable. @steveklabnik close?

lnicola pushed a commit to lnicola/rust that referenced this issue Oct 17, 2024
@bors
Auto merge of rust-lang#18216 - davidbarsky:davidbarsky/push-ustyovtq…
1a354f6 
…rpoq, r=davidbarsky

internal: switch remaining OpQueues to use named structs

Building atop of rust-lang/rust-analyzer#18195, I switched `GlobalState::fetch_build_data_queue` to use a struct instead of a tuple.

(I didn't switch `fetch_proc_macros_queue` to not return a bool, as the return value is only used in one spot.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-syntaxext Area: Syntax extensions I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @kmcallister @tamird