Skip to content

Update for language changes. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2014
Merged

Update for language changes. #49

merged 1 commit into from
Oct 21, 2014

Conversation

chris-morgan
Copy link
Contributor

No description provided.

@kmcallister
Copy link
Contributor

Thanks. This is deprecated stuff I missed in a old upgrade, d66ab4f.

A rustc bug meant that warnings for ty::Unsafe were not issued. I'm not sure why we missed the stuff in quotes, but quotes are buggy and I've had other warnings-related issues in the past. I'll start a Rust bug thread to track that down.

kmcallister added a commit that referenced this pull request Oct 21, 2014
@kmcallister
Merge pull request #49 from chris-morgan/master
ac56beb 
Update for language changes.
@kmcallister kmcallister merged commit ac56beb into servo:master Oct 21, 2014
@chris-morgan
Copy link
Contributor Author

And as far as the Unsafe part is concerned, that was a pub use, and #[deprecated] doesn’t work on pub use, so that’s why there was no warning there.

@kmcallister kmcallister mentioned this pull request Oct 21, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-morgan @kmcallister