Skip to content

Switch the order of arguments to assert_eq! #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 23, 2013 · 1 comment
Closed

Switch the order of arguments to assert_eq! #7330

brson opened this issue Jun 23, 2013 · 1 comment
Labels
A-grammar Area: The grammar of Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 23, 2013

The usual order in junit is (expected, actual), but we've got the opposite.

Attempted, but not completed in #6847
@emberian
Copy link
Member

emberian commented Aug 5, 2013

I don't think this is important, because we don't use the names expected and actual anymore. Closing.

@emberian emberian closed this as completed Aug 5, 2013
@nielsegberts nielsegberts mentioned this issue Dec 9, 2014
Merged
bors added a commit that referenced this issue Dec 16, 2014
@bors
auto merge of #19647 : nielsegberts/rust/master, r=pnkfelix
4375be6 
The names expected and actual are not used anymore in the output. It also
removes the confusion that the argument order is the opposite of junit.

Bug #7330 is relevant.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 17, 2021
@bors
Auto merge of rust-lang#7330 - xFrednet:0000-refactor-map-identity, r…
da0538e 
…=flip1995

Refactoring identity function lints

I've noticed that we have several lints that all check for identity functions and each used their own check implementation. I moved the `is_expr_identity_function` function to `clippy_utils` and adapted all lints to reuse that one function. This should make the addition of new lints like this also easier in the future.

I've also moved the `map_identity` lint into the `methods` module. It's probably the best to review this PR by checking each commit individually. And that's it, have a great day 🙃

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-grammar Area: The grammar of Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @emberian