Switch expected and actual in assert_eq! #6847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original XUnit was expected, actual, but we had actual, expected. http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertEquals%28double,%20double%29 With the new formatting, this doesn't matter as much, but it's nice to be consistent with previous frameworks, and if we change the output such that it does matter, better to be ready.
|
I'm not entirely sure how to fix this test :/ |
|
I guess that switching the order of the comparisons in the macros might fix it, so |
|
Hm. So maybe this just isn't a good patch? Some frameworks do do it this way, most just do it the other. Maybe best to just leave it alone? |
|
I do prefer the (expected, actual) order. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 25, 2021
Fix `manual_map` suggestion for `if let.. else ... if let.. else` chain fixes: rust-lang#6847 changelog: Fix `manual_map` suggestion for `if let.. else ... if let.. else` chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original XUnit was expected, actual, but we had actual, expected.
http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertEquals%28double,%20double%29
With the new formatting, this doesn't matter as much, but it's nice to be
consistent with previous frameworks, and if we change the output such
that it does matter, better to be ready.