-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Clean up lifetimes in rustdoc syntax highlighting #105530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-lang:master
from
Noratrieb:rustdoc-highlight-less-lifetimes
Dec 11, 2022
Merged
Clean up lifetimes in rustdoc syntax highlighting #105530
bors
merged 1 commit into
rust-lang:master
from
Noratrieb:rustdoc-highlight-less-lifetimes
Dec 11, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a few lifetimes and renames some.
/// This field is used to calculate precise local URLs. | ||
pub(crate) current_href: &'c str, | ||
pub(crate) current_href: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice finding!
GuillaumeGomez
approved these changes
Dec 10, 2022
Thanks! I don't think there is any need for a perf check so let's just approve it. @bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 10, 2022
…ifetimes, r=GuillaumeGomez Clean up lifetimes in rustdoc syntax highlighting Removes a few lifetimes and renames some. r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103146 (Cleanup timeouts in pthread condvar) - rust-lang#105459 (Build rust-analyzer proc-macro server by default) - rust-lang#105460 (Bump compiler-builtins to 0.1.85) - rust-lang#105511 (Update rustix to 0.36.5) - rust-lang#105530 (Clean up lifetimes in rustdoc syntax highlighting) - rust-lang#105534 (Add Nilstrieb to compiler reviewers) - rust-lang#105542 (Some method confirmation code nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few lifetimes and renames some.
r? @GuillaumeGomez