Skip to content

Some method confirmation code nits #105542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2022
Merged

Some method confirmation code nits #105542

merged 1 commit into from
Dec 11, 2022

Conversation

compiler-errors
Copy link
Member

  1. Make some pick methods take &self instead of &mut to avoid some cloning
  2. Pass some values by reference to avoid some cloning
  3. Rename a few variables here and there

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 10, 2022
@compiler-errors compiler-errors added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Dec 10, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 10, 2022

📌 Commit 11ad94d has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2022
@bors
Auto merge of rust-lang#105543 - matthiaskrgr:rollup-s9zj0pq, r=matth…
e1c9121 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103146 (Cleanup timeouts in pthread condvar)
 - rust-lang#105459 (Build rust-analyzer proc-macro server by default)
 - rust-lang#105460 (Bump compiler-builtins to 0.1.85)
 - rust-lang#105511 (Update rustix to 0.36.5)
 - rust-lang#105530 (Clean up lifetimes in rustdoc syntax highlighting)
 - rust-lang#105534 (Add Nilstrieb to compiler reviewers)
 - rust-lang#105542 (Some method confirmation code nits)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 30db3a7 into rust-lang:master Dec 11, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 11, 2022
@compiler-errors compiler-errors deleted the confirm-nits branch August 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-dead fee1-dead

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors @rustbot @jackh726 @bors @fee1-dead