s/Second borrow/Previous borrow/ in error messages. #11025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a borrow occurs twice illegally, Rust will label the other borrow as the "second borrow". This is quite confusing, as the "second borrow" usually happened before the flagged borrow (e.g. as far as dataflow is concerned, the first borrow is OK, the second borrow is illegal.) This patch renames "second borrow" to "previous borrow", to make the spatial relationship between the two borrows clearer. Signed-off-by: Edward Z. Yang <[email protected]>
bors
added a commit
that referenced
this pull request
Dec 18, 2013
When a borrow occurs twice illegally, Rust will label the other borrow as the "second borrow". This is quite confusing, as the "second borrow" usually happened before the flagged barrow (e.g. as far as dataflow is concerned, the first borrow is OK, the second borrow is illegal.) This patch renames "second borrow" to "previous borrow", to make the spatial relationship between the two borrows clearer. Signed-off-by: Edward Z. Yang <[email protected]>
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
This commit fixes rust-lang#11025 by removing checks for `todo!`, `unimplemented!` and `unreachable!`. Signed-off-by: Panagiotis Foliadis <[email protected]>
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
[`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!` This commit fixes rust-lang#11025 by removing checks for `todo!`, `unimplemented!` and `unreachable!`. changelog: [`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a borrow occurs twice illegally, Rust will label the other borrow
as the "second borrow". This is quite confusing, as the "second borrow"
usually happened before the flagged barrow (e.g. as far as dataflow
is concerned, the first borrow is OK, the second borrow is illegal.)
This patch renames "second borrow" to "previous borrow", to make the
spatial relationship between the two borrows clearer.
Signed-off-by: Edward Z. Yang [email protected]