-
Notifications
You must be signed in to change notification settings - Fork 13.3k
First phase of migrating the wiki to the internal docs #11078 #11123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First phase of migrating the wiki to the internal docs #11078 #11123
Conversation
I'm quite OK with this. |
Issue #5831 is relevant to this PR (and probably means it can not be blindly merged). |
Yikes, that's a pain. |
Every internal Manual, Guide (Tutorial) or other Documentation, could contain the License at the bottom declaring the double license as per COPYRIGHT.txt How does that sound ? After approved we could deprecate the wiki ? |
@alanandrade that isn't the problem, the problem is that the wiki basically has no license at all. Everything is copyrighted by the author. |
I'll ask every author for the copyright transfer. The official permission would be a comment on this pull request. This won't be merged until we get every author grant and we all agree the terms. |
According to last commit.Assumptions:
That means we need the permission of 11 contributors according to this page: https://github.com/mozilla/rust/wiki/Doc-language-FAQ/_history if we want to merge the Language FAQ page transcription. Do we need the permission of contributors that only changed small portions ? About the planIt feels sloppy :( but I don't know what to do to solve it faster and effectively. |
I like this idea. The license issue is tricky. Theoretically you need every contributor to sign off... |
The file that lists users groups and so forth sounds wiki-ish to me. |
I want to get this merged for 0.9. Let's move forward with the transfer and ignore the licensing issues for now. I'll talk to the lawyers about what we should do with the documentation licensing. I'd like to make some changes though:
I'm not sure about the community stuff, but I'm inclined to leave it there so people can find it easily. Sorry I took so long to look at this. |
All right, we have the most important wikis here. Ready for review or +r stuff ;) |
@alan-andrade You still have |
@adridu59 My bad, I believe its ready now. |
#TOC ul ul { | ||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely stay. manual.inc
is here to overwrite this rule for select files.
However tutorial + guides should keep this rule, at least this is the current policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this could be better done by passing --toc-depth=1 to pandoc by default.
Also, I'm interested in using a depth of 2 for FAQs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see the connection of what you're saying.
Of course I want to go with the current policy, but my gut is telling me that overriding CSS just to hide ul's is not very clean. If we have an option to not even display the uls that we don't want, then why not use it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, display: none
doesn't hide, it just doesn't display; hiding would be visibility: hidden
.
@adridu59 ok, hopefully this is the last time I bother you 👍 |
doc/rust.css: rust.css | ||
@$(call E, cp: $@) | ||
$(Q)cp -a $< $@ 2> /dev/null | ||
|
||
doc/manual.inc: manual.inc | ||
HTML_DEPS += doc/full-toc.inc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only want this for rust.md
(Manual) and not for Tutorial/Guides, or are you willing to use it elsewhere?
My understanding is that only the reference manual should have that heavyweight full toc (tutorials are more meant to be followed at least by-section).
I agree that all the docs should depend on |
oh, and every html will include version_info just as HTML_OPTS describes. |
Thanks @alan-andrade |
…r=brson This is not done yet but I'm posting it to get feedback. The wiki has a ton of different tutorials/manuals/faq and so forth. Instead of migrating all of them right now, I just migrated the following: * The general main wiki page * Language FAQ * Project FAQ If this feels reasonable, please comment so that I can continue with confidence.
I think this will fail because |
@brson @adridu59 rust-lang/prev.rust-lang.org#19 |
[`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!` This commit fixes rust-lang#11025 by removing checks for `todo!`, `unimplemented!` and `unreachable!`. changelog: [`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!`
This is not done yet but I'm posting it to get feedback.
The wiki has a ton of different tutorials/manuals/faq and so forth. Instead of migrating all of them right now, I just migrated the following:
If this feels reasonable, please comment so that I can continue with confidence.