Fix #889: Add warnings about unused imports #1169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I'm glad to finally discover all of our unused imports. Can you add a test for this feature before I pull it? Since this is just a warning and we don't have a testing mode specifically for testing warnings, you'll have to create a test case under src/test/compile-fail that generates this warning and then fails for other reasons, then your "error-pattern" line will just check for the unused import warning. |
|
Rewrite the commit history by adding a test case as asked. |
|
Thanks! Integrated. |
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
May 27, 2021
Set correct segment from #[link_section] for MachO
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is done in resolve.rs. An import is "used", if it is the result of resolving a name in resolve_names function.
The two other commits are cleanup of reported warnings of unused imports.
Please review.