Skip to content

Fix #889: Add warnings about unused imports #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/comp/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,18 @@ import metadata::{encoder, cstore};
import middle::trans_common::crate_ctxt;
import std::str;
import std::fs;
import std::os;
import std::vec;
import std::option;
import std::run;
import option::some;
import option::none;
import std::sha1::sha1;
import std::sort;
import syntax::ast;
import syntax::print::pprust;
import lib::llvm::llvm::ModuleRef;
import lib::llvm::llvm::ValueRef;
import lib::llvm::mk_pass_manager;
import lib::llvm::mk_target_data;
import lib::llvm::mk_type_names;
import lib::llvm::False;
import lib::llvm::True;
import util::filesearch;

tag output_type {
Expand Down
4 changes: 1 addition & 3 deletions src/comp/back/target_strs.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import std::str;

type t = {
module_asm: str,
meta_sect_name: str,
data_layout: str,
target_triple: str,
gcc_args: [str]
};
};
8 changes: 3 additions & 5 deletions src/comp/back/upcall.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@

import std::str;
import driver::session;
import middle::trans;
import trans::decl_cdecl_fn;
import middle::trans_common::{T_f32, T_f64, T_fn, T_bool, T_i1, T_i8, T_i32,
T_i64, T_int, T_vec, T_nil, T_opaque_chan_ptr,
T_opaque_vec, T_opaque_port_ptr, T_ptr,
import middle::trans_common::{T_fn, T_i1, T_i8, T_i32,
T_i64, T_int, T_nil,
T_opaque_vec, T_ptr,
T_size_t, T_void, T_float};
import lib::llvm::type_names;
import lib::llvm::llvm::ModuleRef;
Expand Down
3 changes: 0 additions & 3 deletions src/comp/back/x86.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import lib::llvm::llvm;
import lib::llvm::llvm::ModuleRef;
import std::str;
import driver::session;

fn get_target_strs(target_os: session::os) -> target_strs::t {
Expand Down
3 changes: 0 additions & 3 deletions src/comp/back/x86_64.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import lib::llvm::llvm;
import lib::llvm::llvm::ModuleRef;
import std::str;
import driver::session;

fn get_target_strs(target_os: session::os) -> target_strs::t {
Expand Down
10 changes: 3 additions & 7 deletions src/comp/driver/rustc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,16 @@

// -*- rust -*-
import metadata::{creader, cstore};
import syntax::parse::{parser, token};
import syntax::parse::{parser};
import syntax::{ast, codemap};
import front::attr;
import middle::{trans, resolve, freevars, kind, ty, typeck, fn_usage};
import middle::tstate::ck;
import syntax::print::{pp, pprust};
import util::{ppaux, common, filesearch};
import util::{ppaux, filesearch};
import back::link;
import lib::llvm;
import std::{fs, option, str, vec, int, io, run, getopts, result};
import std::map::mk_hashmap;
import std::{option, str, vec, int, io, getopts, result};
import std::option::{some, none};
import std::getopts::{optopt, optmulti, optflag, optflagopt, opt_present};
import back::link::output_type;
import back::{x86, x86_64};

tag pp_mode { ppm_normal; ppm_expanded; ppm_typed; ppm_identified; }
Expand Down
2 changes: 1 addition & 1 deletion src/comp/driver/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import syntax::{ast, codemap};
import syntax::ast::node_id;
import codemap::span;
import syntax::ast::ty_mach;
import std::{uint, map, option, str};
import std::{option};
import std::option::{some, none};
import syntax::parse::parser::parse_sess;
import util::filesearch;
Expand Down
3 changes: 1 addition & 2 deletions src/comp/front/attr.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Functions dealing with attributes and meta_items

import std::{vec, str, map, option};
import std::{vec, map, option};
import syntax::{ast, ast_util};
import util::common;
import driver::session;

export attr_meta;
Expand Down
2 changes: 1 addition & 1 deletion src/comp/front/test.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Code that generates a test runner to run all the tests in a crate

import std::{option, vec, str};
import std::{option, vec};
import syntax::{ast, ast_util};
import syntax::ast_util::*;
//import syntax::ast_util::dummy_sp;
Expand Down
6 changes: 2 additions & 4 deletions src/comp/lib/llvm.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import std::{vec, str, option};
import std::str::sbuf;

import llvm::{ModuleRef, ContextRef, TypeRef, TypeHandleRef, ValueRef,
BasicBlockRef, BuilderRef, ModuleProviderRef, MemoryBufferRef,
PassManagerRef, UseRef, TargetDataRef, Linkage, Attribute,
Visibility, CallConv, IntPredicate, RealPredicate, Opcode,
import llvm::{TypeRef, MemoryBufferRef,
PassManagerRef, TargetDataRef,
ObjectFileRef, SectionIteratorRef};

type ULongLong = u64;
Expand Down
4 changes: 1 addition & 3 deletions src/comp/metadata/creader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ import driver::session;
import syntax::{ast, ast_util};
import lib::llvm::{False, llvm, mk_object_file, mk_section_iter};
import front::attr;
import middle::resolve;
import syntax::visit;
import syntax::codemap::span;
import back::x86;
import util::{common, filesearch};
import util::{filesearch};
import std::{vec, str, fs, io, option};
import std::option::{none, some};
import std::map::{hashmap, new_int_hash};
Expand Down
2 changes: 0 additions & 2 deletions src/comp/metadata/decoder.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
// Decoding metadata from a single crate's metadata

import std::{ebml, vec, option, str, io};
import std::map::hashmap;
import syntax::{ast, ast_util};
import front::attr;
import middle::ty;
import common::*;
import tydecode::{parse_def_id, parse_ty_data};
import driver::session;
import syntax::print::pprust;
import cstore;

Expand Down
3 changes: 1 addition & 2 deletions src/comp/metadata/encoder.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Metadata encoding

import std::{vec, str, uint, io, option, ebml, map};
import std::option::{some, none};
import std::{vec, str, uint, io, ebml, map};
import syntax::ast::*;
import syntax::ast_util;
import syntax::ast_util::local_def;
Expand Down
2 changes: 1 addition & 1 deletion src/comp/metadata/tydecode.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Type decoding

import std::{vec, str, uint, option};
import std::{vec, str, uint};
import std::option::{none, some};
import syntax::ast;
import syntax::ast::*;
Expand Down
3 changes: 1 addition & 2 deletions src/comp/metadata/tyencode.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
// Type encoding

import std::{str, io, int, uint};
import std::{io, int, uint};
import std::map::hashmap;
import std::option::{some, none};
import syntax::ast::*;
import middle::ty;
import syntax::print::pprust::*;
import util::common;

export ctxt;
export ty_abbrev;
Expand Down
4 changes: 2 additions & 2 deletions src/comp/middle/alias.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

import syntax::{ast, ast_util};
import ast::{ident, fn_ident, node_id, def_id};
import ast::{ident, fn_ident, node_id};
import syntax::codemap::span;
import syntax::visit;
import visit::vt;
import std::{vec, str, option};
import std::{vec, option};
import std::option::{some, none, is_none};

// This is not an alias-analyser (though it would merit from becoming one, or
Expand Down
1 change: 0 additions & 1 deletion src/comp/middle/ast_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import std::{smallintmap, option};
import syntax::ast::*;
import syntax::ast_util;
import syntax::{visit, codemap};
import visit::vt;

tag ast_node {
node_item(@item);
Expand Down
1 change: 0 additions & 1 deletion src/comp/middle/check_const.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import syntax::ast::*;
import syntax::ast_util::{variant_def_ids, dummy_sp};
import syntax::visit;

fn check_crate(tcx: ty::ctxt, crate: @crate) {
Expand Down
2 changes: 1 addition & 1 deletion src/comp/middle/fn_usage.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import syntax::ast;
import syntax::visit;
import std::option::some;
import syntax::print::pprust::{expr_to_str, path_to_str};
import syntax::print::pprust::expr_to_str;

export check_crate_fn_usage;

Expand Down
3 changes: 1 addition & 2 deletions src/comp/middle/freevars.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
// A pass that annotates for each loops and functions with the free
// variables that they contain.

import std::{map, option, int, str};
import std::{int};
import std::map::*;
import std::option::*;
import syntax::{ast, ast_util, visit};
import driver::session;
import middle::resolve;
import syntax::codemap::span;

Expand Down
6 changes: 3 additions & 3 deletions src/comp/middle/gc.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Routines useful for garbage collection.

import lib::llvm::{True, False};
import lib::llvm::True;
import lib::llvm::llvm::ValueRef;
import middle::trans;
import middle::trans::{get_tydesc, tps_normal};
import middle::trans_common::*;
import middle::ty;
import std::option::{some, none};
import std::{ptr, str, unsafe, vec};
import std::option::none;
import std::str;

import lll = lib::llvm::llvm;
import bld = trans_build;
Expand Down
2 changes: 1 addition & 1 deletion src/comp/middle/kind.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
*/

import syntax::{ast, ast_util, visit, codemap};
import std::{vec, option, str};
import std::{vec, option};
import ast::{kind, kind_unique, kind_shared, kind_pinned};

fn kind_lteq(a: kind, b: kind) -> bool {
Expand Down
Loading