exact_div: add tests #141939
Merged
exact_div: add tests #141939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Qelxiros
force-pushed
the
139911-exact-div-tests
branch
from
00e7551 to
2c4e592
Compare
This comment has been minimized.
This comment has been minimized.
Qelxiros
force-pushed
the
139911-exact-div-tests
branch
from
2c4e592 to
b72cf24
Compare
This comment has been minimized.
This comment has been minimized.
Qelxiros
force-pushed
the
139911-exact-div-tests
branch
from
b72cf24 to
e87f138
Compare
|
|
||
| // failures | ||
| assert_eq_const_safe!(Option<$T>: <$T>::checked_exact_div(1, 2), None); | ||
| assert_eq_const_safe!(Option<$T>: <$T>::checked_exact_div(0, 0), None); |
There was a problem hiding this comment.
I suppose we could test (<$T>::MAX >> 1) + 1 divided by -1 as _ for unsigned integers, but it would just also be None, for the same reason 1, 2 is.
There was a problem hiding this comment.
I'm not sure what, if anything, you want me to change here.
There was a problem hiding this comment.
Nada, just thought process effluvia.
|
feels weird to test signed integers without testing negative cases @rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
tgross35
reviewed
Jun 4, 2025
Comment on lines
+703
to
+707
| assert_eq_const_safe!(Option<$T>: <$T>::checked_exact_div(EXACT_DIV_SUCCESS_DIVIDEND1, EXACT_DIV_SUCCESS_DIVISOR1), Some(EXACT_DIV_SUCCESS_QUOTIENT1)); | ||
| assert_eq_const_safe!($T: <$T>::exact_div(EXACT_DIV_SUCCESS_DIVIDEND1, EXACT_DIV_SUCCESS_DIVISOR1), EXACT_DIV_SUCCESS_QUOTIENT1); | ||
|
|
||
| // 18 / 3 | ||
| assert_eq_const_safe!(Option<$T>: <$T>::checked_exact_div(EXACT_DIV_SUCCESS_DIVIDEND2, EXACT_DIV_SUCCESS_DIVISOR2), Some(EXACT_DIV_SUCCESS_QUOTIENT2)); |
There was a problem hiding this comment.
Not to necessarily block anything, but maybe want to hand wrap these so they don't wrap in the UI?
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 4, 2025
…=workingjubilee exact_div: add tests tracking issue: rust-lang#139911 I neglected to add tests in my last PR (rust-lang#141237), so I've added them here. r? `@workingjubilee` (Feel free to reroll, I just picked you since you reviewed the last one.)
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 7 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #139911
I neglected to add tests in my last PR (#141237), so I've added them here.
r? @workingjubilee (Feel free to reroll, I just picked you since you reviewed the last one.)