-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 9 pull requests #142020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 9 pull requests #142020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are unused.
They're equivalent, and `path` is unused, and `deconstruct` has only one call site outside of `path`.
And avoid the clone.
- Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure
These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
For AST/HIR/THIR visitors, explain the use of deconstruction.
…flexible macro to generate them
…nszelmann Streamline some attr parsing APIs r? `@jdonszelmann`
…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? `@workingjubilee` should we remove this function? since it's used in several places, i'd prefer to keep it.
coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on rust-lang#141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR.
remove `f16: From<u16>` it's not a lossless conversion r? `@tgross35`
Lightly tweak docs for BTree{Map,Set}::extract_if - Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure Related rust-lang#70530
…=workingjubilee exact_div: add tests tracking issue: rust-lang#139911 I neglected to add tests in my last PR (rust-lang#141237), so I've added them here. r? `@workingjubilee` (Feel free to reroll, I just picked you since you reviewed the last one.)
…es2, r=compiler-errors Add more missing 2015 edition directives These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
redesign stage 0 std follow-ups part2 Fixes three bugs: 1. `x check` fails when run on rustdoc without `download-rustc` enabled. (1st commit) 2. `x check` fails when run on the compiler with `download-rustc` enabled. (2nd commit) 3. `x test library` fails with `download-rustc` enabled. (3rd commit) Fixes rust-lang#142018 (case 1) Fixes rust-lang#141983 (case 3)
…enyukang Improve some `Visitor` comments. For AST/HIR/THIR visitors, explain the use of deconstruction. r? `@BoxyUwU`
@bors r+ rollup=never p=5 |
@bors p=11 since we included the bootstrap fixes here |
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-attributes
Area: Attributes (`#[…]`, `#![…]`)
A-testsuite
Area: The testsuite used to check the correctness of rustc
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
f16: From<u16>
#141893 (removef16: From<u16>
)Visitor
comments. #142007 (Improve someVisitor
comments.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup