Skip to content

Rollup of 9 pull requests #142020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jun 4, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

nnethercote and others added 26 commits May 20, 2025 11:58
They're equivalent, and `path` is unused, and `deconstruct` has only one
call site outside of `path`.
- Move explanations into comments to match style
- Explain the second examples
- Make variable names match the data structure
These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
For AST/HIR/THIR visitors, explain the use of deconstruction.
…nszelmann

Streamline some attr parsing APIs

r? `@jdonszelmann`
…, r=workingjubilee

Fix incorrect eq_unspanned in TokenStream

Fixes rust-lang#141522

r? `@workingjubilee`

should we remove this function?
since it's used in several places, i'd prefer to keep it.
coretests: move float tests from num to floats module and use a more flexible macro to generate them

This makes some progress on rust-lang#141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough.

I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR.
remove `f16: From<u16>`

it's not a lossless conversion

r? `@tgross35`
Lightly tweak docs for BTree{Map,Set}::extract_if

- Move explanations into comments to match style
- Explain the second examples
- Make variable names match the data structure

Related rust-lang#70530
…=workingjubilee

exact_div: add tests

tracking issue: rust-lang#139911

I neglected to add tests in my last PR (rust-lang#141237), so I've added them here.

r? `@workingjubilee` (Feel free to reroll, I just picked you since you reviewed the last one.)
…es2, r=compiler-errors

Add more missing 2015 edition directives

These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
redesign stage 0 std follow-ups part2

Fixes three bugs:

1. `x check` fails when run on rustdoc without `download-rustc` enabled. (1st commit)
2. `x check` fails when run on the compiler with `download-rustc` enabled. (2nd commit)
3. `x test library` fails with `download-rustc` enabled. (3rd commit)

Fixes rust-lang#142018 (case 1)
Fixes rust-lang#141983 (case 3)
…enyukang

Improve some `Visitor` comments.

For AST/HIR/THIR visitors, explain the use of deconstruction.

r? `@BoxyUwU`
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 4, 2025
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 4, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit 182e9f6 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@matthiaskrgr
Copy link
Member Author

@bors p=11 since we included the bootstrap fixes here

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

⌛ Testing commit 182e9f6 with merge f9cb39b...

bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 9 pull requests

Successful merges:

 - #141271 (Streamline some attr parsing APIs)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141939 (exact_div: add tests)
 - #141959 (Add more missing 2015 edition directives)
 - #142002 (redesign stage 0 std follow-ups part2)
 - #142007 (Improve some `Visitor` comments.)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
1800 |         unsafe { intrinsics::powif128(self, n) }
     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unimplemented intrinsic: `powif128`
     |
     = help: this is likely not a bug in the program; it indicates that the program performed an operation that Miri does not support
     = note: BACKTRACE on thread `floats::midpoin`:
     = note: inside `core::f128::<impl f128>::powi` at /checkout/library/core/src/num/f128.rs:1800:18: 1800:47
note: inside `floats::midpoint_large_magnitude::test_f128`
    --> library/coretests/tests/floats/mod.rs:402:44
     |
402  |                 let large = (2.0 as Float).powi(i);
     |                                            ^^^^^^^
note: inside closure
    --> library/coretests/tests/floats/mod.rs:127:27
     |
87   | / macro_rules! float_test {
88   | |     (
89   | |         name: $name:ident,
90   | |         attrs: {
...    |
125  | |             #[test]
     | |             ------- in this procedural macro expansion (#2)
126  | |             $( $( #[$f128_meta] )+ )?
127  | |             fn test_f128() {
     | |                           ^
...    |
165  | |     };
166  | | }
     | |_- in this expansion of `float_test!` (#1)
...
387  | / float_test! {
388  | |     name: midpoint_large_magnitude,
389  | |     attrs: {
390  | |         const: #[cfg(false)],
...    |
416  | | }
     | |_- in this macro invocation (#1)
     |
    ::: /checkout/library/core/src/macros/mod.rs:1675:5
     |
1675 |       pub macro test($item:item) {
     |       -------------- in this expansion of `#[test]` (#2)
note: inside `<{closure@library/coretests/tests/floats/mod.rs:127:13: 130:14} as std::ops::FnOnce<()>>::call_once - shim`
    --> /checkout/library/core/src/ops/function.rs:250:5
     |
250  |     extern "rust-call" fn call_once(self, args: Args) -> Self::Output;
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `<fn() -> std::result::Result<(), std::string::String> as std::ops::FnOnce<()>>::call_once - shim(fn() -> std::result::Result<(), std::string::String>)`
---

error: test failed, to rerun pass `-p coretests --test coretests`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/cargo-miri runner /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/miri/x86_64-unknown-linux-gnu/debug/deps/coretests-41766f620c5c8ff7 -Z unstable-options --format json` (exit status: 1)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
Build completed unsuccessfully in 0:16:46
make: *** [Makefile:53: check-aux] Error 1
  local time: Wed Jun  4 14:13:47 UTC 2025
  network time: Wed, 04 Jun 2025 14:13:47 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.