Rollup of 9 pull requests #141954

matthiaskrgr · 2025-06-03T09:33:38Z

Successful merges:

Improve documentation for codegen options #141554 (Improve documentation for codegen options)
rustc_llvm: add Windows system libs only when cross-compiling from Wi… #141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…)
Add visit_id to ast Visitor #141843 (Add visit_id to ast Visitor)
Subtree update of rust-analyzer #141881 (Subtree update of rust-analyzer)
[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id #141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id)
Disable f64 minimum/maximum tests for arm 32 #141921 (Disable f64 minimum/maximum tests for arm 32)
Enable triagebot [concern] functionality #141930 (Enable triagebot [concern] functionality)
Decouple "reporting in deps" from FutureIncompatibilityReason #141936 (Decouple "reporting in deps" from FutureIncompatibilityReason)
move test-float-parse tool into src/tools dir #141949 (move test-float-parse tool into src/tools dir)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…ng#10725)

fix: Recognize salsa cycles in `thread_result_to_response`

fix: Fix import insertion not being fully cfg aware

…efs-constructor-search docs: add documentation for find_all_refs constructor search

internal: Restructure some semantics APIs for virtual macro files

refactor: Remove unncessary duplication in highlight_related

Account for `Generate` actions when filtering the allowed ones

fix: Fix manual not containing diagnostics documentation

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

This helps with efforts to deduplicate the `MutVisitor` and the `Visitor` code. All users of `Visitor`'s methods that have extra `NodeId` as parameters really just want to visit the id on its own. Also includes some methods deduplicated and cleaned up as a result of this change.

This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior.

This disables the f64 minimum/maximum tests for the arm-unknown-linux-gnueabihf job. The next release will be supporting cross-compiled doctests, and these tests fail on that platform. It looks like this was just fixed via llvm/llvm-project#142170, but I assume that will not trickle down to our copy of llvm in the next couple of weeks. Assuming that does get fixed when llvm is updated, then these can be removed. cc rust-lang#141087

Obviously `test-float-parse` is a tool like any other in `src/tools`. Signed-off-by: onur-ozkan <[email protected]>

…tter, r=bjorn3 Improve documentation for codegen options This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior. r? bjorn3

…-compiling, r=cuviper rustc_llvm: add Windows system libs only when cross-compiling from Wi… …ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772 Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)

…t_id, r=oli-obk Add `visit_id` to ast `Visitor` This helps with efforts to deduplicate the `MutVisitor` and the `Visitor` code. All users of `Visitor`'s methods that have extra `NodeId` as parameters really just want to visit the id on its own. Also includes some methods deduplicated and cleaned up as a result of this change. r? oli-obk

Enable triagebot `[concern]` functionality Documentation at: https://forge.rust-lang.org/triagebot/concern.html Example at: rust-lang/triagebot#2024 r? Kobzol

…ling, r=oli-obk Decouple "reporting in deps" from `FutureIncompatibilityReason` The reason should just be it -- the reason. It never felt right to me that it was also responsible for whatever we include the warning in cargo's reports. It gets especially unruly if you want to add non-`FutureReleaseError*` warnings which are included in the reports. I just added a field to `FutureIncompatibleInfo` to control whatever the diagnostic is included in the cargo's reports.

…r=Kobzol move `test-float-parse` tool into `src/tools` dir Obviously `test-float-parse` is a tool like any other in `src/tools`. cc `@tgross35`

matthiaskrgr · 2025-06-03T09:33:52Z

@bors r+ rollup=never p=5

bors · 2025-06-03T09:33:55Z

📌 Commit 2fa33b0 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-06-03T09:52:03Z

⌛ Testing commit 2fa33b0 with merge 2f17612...

bors · 2025-06-03T13:07:39Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2f17612 to master...

rust-timer · 2025-06-03T13:10:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141554	Improve documentation for codegen options	`3dcb6cf921951c1b396e2fe5407b0f252dcb0853` (link)
#141817	rustc_llvm: add Windows system libs only when cross-compili…	`0b55b506f6a95f12697e65cd13a9793abaad3b1f` (link)
#141843	Add `visit_id` to ast `Visitor`	`5590a8cb9e8477eb2637f35ec4d54141ed79ed81` (link)
#141881	Subtree update of `rust-analyzer`	`6c875cc6552c67ea4c5e844ba9bf618903af5dbd` (link)
#141898	[rustdoc-json] Implement PartialOrd and Ord for rustdoc_typ…	`f21c96f240490602bcfa450ded61cfb5699a9856` (link)
#141921	Disable f64 minimum/maximum tests for arm 32	`7b9193444b3fb74393975771a48f4525acf4891e` (link)
#141930	Enable triagebot `[concern]` functionality	`1133bf285e739fc5537c9eea58b7d90a4efa8852` (link)
#141936	Decouple "reporting in deps" from `FutureIncompatibilityRea…	`00a762964417ce943ef46496b666aa3e2e4203ad` (link)
#141949	move `test-float-parse` tool into `src/tools` dir	`60430d066f1add256682997411f2255f280a0176` (link)

previous master: c68032fd4c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-03T13:10:21Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c68032f (parent) -> 2f17612 (this PR)

Test differences

Show 278 test diffs

278 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2f176126aaf3fd316fc5ced3d9a111a48797b52c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 8415.5s -> 6848.4s (-18.6%)
x86_64-apple-2: 6250.0s -> 5161.8s (-17.4%)
dist-s390x-linux: 5196.7s -> 5626.9s (8.3%)
dist-aarch64-apple: 6086.7s -> 6519.2s (7.1%)
dist-apple-various: 7753.8s -> 7333.7s (-5.4%)
i686-msvc-2: 7548.0s -> 7188.9s (-4.8%)
aarch64-gnu-debug: 3998.6s -> 3829.7s (-4.2%)
i686-gnu-nopt-2: 6496.9s -> 6736.8s (3.7%)
x86_64-gnu-llvm-20-1: 3883.5s -> 3744.0s (-3.6%)
x86_64-gnu-llvm-19-1: 3828.0s -> 3690.5s (-3.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-04T00:26:42Z

Finished benchmarking commit (2f17612): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Max RSS (memory usage)

Results (secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[1.4%, 7.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 743.521s -> 744.283s (0.10%)
Artifact size: 372.32 MiB -> 372.30 MiB (-0.01%)

vremyavnikuda and others added 30 commits May 26, 2025 15:51

docs: add documentation for find_all_refs constructor search (rust-la…

44612c5

…ng#10725)

fix: the lines are formatted according to clippy

1e8eacd

fix: the lines are formatted according to clippy

693ff34

fix: formated to clippy

57707c2

docs:deleting duplicate documentation

430f75a

fix: Recognize salsa cycles in thread_result_to_response

d2bc368

Merge pull request rust-lang#19888 from Veykril/push-wylsryzpnnop

f06e376

fix: Recognize salsa cycles in `thread_result_to_response`

fix: Fix import insertion not being fully cfg aware

087cfe3

Merge pull request rust-lang#19890 from Veykril/push-kzzntrpllsqx

23738b5

fix: Fix import insertion not being fully cfg aware

Merge pull request rust-lang#19861 from vremyavnikuda/docs/find-all-r…

8d958aa

…efs-constructor-search docs: add documentation for find_all_refs constructor search

Add some more hir_expand::files conversions

1b809b7

internal: Restructure some semantics APIs for virtual macro files

1383bca

Merge pull request rust-lang#19896 from Veykril/push-qyutrlxyznum

deeb464

internal: Restructure some semantics APIs for virtual macro files

refactor: Remove unncessary duplication in highlight_related

ed508c7

Merge pull request rust-lang#19898 from Veykril/push-ykumpuwmuvmu

9c45a45

refactor: Remove unncessary duplication in highlight_related

Account for Generate actions when filtering the allowed ones

1b9fb33

Merge pull request rust-lang#19899 from SomeoneToIgnore/generate-actions

cac7468

Account for `Generate` actions when filtering the allowed ones

fix: Fix manual not containing diagnostics documentation

2428070

Merge pull request rust-lang#19900 from Veykril/push-zurosouxqxzz

01a1908

fix: Fix manual not containing diagnostics documentation

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

81f61ac

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

Improve documentation for codegen options

198e89b

This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior.

[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id

6be3c3c

Enable triagebot [concern] functionality

53e0232

move test-float-parse tool into src/tools dir

59fbe04

Obviously `test-float-parse` is a tool like any other in `src/tools`. Signed-off-by: onur-ozkan <[email protected]>

decouple "reporting in deps" from future incompatibility reason

9b7da4d

Rollup merge of rust-lang#141554 - Noratrieb:document-codegen-opts-be…

807778a

…tter, r=bjorn3 Improve documentation for codegen options This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior. r? bjorn3

matthiaskrgr added 3 commits June 3, 2025 11:33

Rollup merge of rust-lang#141930 - Urgau:triagebot_concern, r=Kobzol

94da3d9

Enable triagebot `[concern]` functionality Documentation at: https://forge.rust-lang.org/triagebot/concern.html Example at: rust-lang/triagebot#2024 r? Kobzol

Rollup merge of rust-lang#141949 - onur-ozkan:move-test-float-parse, …

2fa33b0

…r=Kobzol move `test-float-parse` tool into `src/tools` dir Obviously `test-float-parse` is a tool like any other in `src/tools`. cc `@tgross35`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 3, 2025

bors merged commit 2f17612 into rust-lang:master Jun 3, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 3, 2025

This was referenced Jun 3, 2025

Remove wasm legacy abi #133952

Open

Add checking for unnecessary delims in closure body #136906

Open

Use lld by default on x86_64-unknown-linux-gnu stable #140525

Open

Report never type lints in dependencies #141937

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #141954

Rollup of 9 pull requests #141954

Uh oh!

matthiaskrgr commented Jun 3, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

rust-timer commented Jun 4, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #141954

Rollup of 9 pull requests #141954

Uh oh!

Conversation

matthiaskrgr commented Jun 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 4, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Jun 3, 2025 •

edited by rustbot

Loading