Skip to content

Rollup of 9 pull requests #141954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jun 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
44612c5
docs: add documentation for find_all_refs constructor search (#10725)
vremyavnikuda May 25, 2025
1e8eacd
fix: the lines are formatted according to clippy
vremyavnikuda May 25, 2025
693ff34
fix: the lines are formatted according to clippy
vremyavnikuda May 25, 2025
57707c2
fix: formated to clippy
vremyavnikuda May 26, 2025
430f75a
docs:deleting duplicate documentation
vremyavnikuda May 28, 2025
d2bc368
fix: Recognize salsa cycles in `thread_result_to_response`
Veykril May 28, 2025
f06e376
Merge pull request #19888 from Veykril/push-wylsryzpnnop
Veykril May 29, 2025
087cfe3
fix: Fix import insertion not being fully cfg aware
Veykril May 28, 2025
23738b5
Merge pull request #19890 from Veykril/push-kzzntrpllsqx
Veykril May 29, 2025
8d958aa
Merge pull request #19861 from vremyavnikuda/docs/find-all-refs-const…
Veykril May 30, 2025
1b809b7
Add some more `hir_expand::files` conversions
Veykril May 30, 2025
1383bca
internal: Restructure some semantics APIs for virtual macro files
Veykril May 30, 2025
deeb464
Merge pull request #19896 from Veykril/push-qyutrlxyznum
Veykril May 30, 2025
ed508c7
refactor: Remove unncessary duplication in highlight_related
Veykril May 31, 2025
9c45a45
Merge pull request #19898 from Veykril/push-ykumpuwmuvmu
Veykril May 31, 2025
1b9fb33
Account for `Generate` actions when filtering the allowed ones
SomeoneToIgnore May 31, 2025
cac7468
Merge pull request #19899 from SomeoneToIgnore/generate-actions
Veykril May 31, 2025
2428070
fix: Fix manual not containing diagnostics documentation
Veykril May 31, 2025
01a1908
Merge pull request #19900 from Veykril/push-zurosouxqxzz
Veykril May 31, 2025
81f61ac
rustc_llvm: add Windows system libs only when cross-compiling from Wi…
mati865 Apr 27, 2025
c33b085
Add `visit_id` to ast `Visitor`
fee1-dead Jun 1, 2025
198e89b
Improve documentation for codegen options
Noratrieb May 25, 2025
6be3c3c
[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id
LukeMathWalker Jun 2, 2025
b0041b8
Disable f64 minimum/maximum tests for arm 32
ehuss Jun 2, 2025
53e0232
Enable triagebot `[concern]` functionality
Urgau Jun 2, 2025
59fbe04
move `test-float-parse` tool into `src/tools` dir
onur-ozkan Jun 3, 2025
9b7da4d
decouple "reporting in deps" from future incompatibility reason
WaffleLapkin Jun 2, 2025
807778a
Rollup merge of #141554 - Noratrieb:document-codegen-opts-better, r=b…
matthiaskrgr Jun 3, 2025
2da4bae
Rollup merge of #141817 - mati865:fix-system-libs-when-cross-compilin…
matthiaskrgr Jun 3, 2025
ad876cb
Rollup merge of #141843 - fee1-dead-contrib:ast_visitor_visit_id, r=o…
matthiaskrgr Jun 3, 2025
1e1e188
Rollup merge of #141881 - lnicola:sync-from-ra, r=lnicola
matthiaskrgr Jun 3, 2025
8fbf365
Rollup merge of #141898 - LukeMathWalker:patch-1, r=aDotInTheVoid
matthiaskrgr Jun 3, 2025
7e8a8c9
Rollup merge of #141921 - ehuss:arm-min-max, r=tgross35
matthiaskrgr Jun 3, 2025
94da3d9
Rollup merge of #141930 - Urgau:triagebot_concern, r=Kobzol
matthiaskrgr Jun 3, 2025
7100905
Rollup merge of #141936 - WaffleLapkin:report-in-deps-decoupling, r=o…
matthiaskrgr Jun 3, 2025
2fa33b0
Rollup merge of #141949 - onur-ozkan:move-test-float-parse, r=Kobzol
matthiaskrgr Jun 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ members = [
# tidy-alphabetical-start
"compiler/rustc",
"src/build_helper",
"src/etc/test-float-parse",
"src/rustc-std-workspace/rustc-std-workspace-alloc",
"src/rustc-std-workspace/rustc-std-workspace-core",
"src/rustc-std-workspace/rustc-std-workspace-std",
Expand Down Expand Up @@ -41,6 +40,7 @@ members = [
"src/tools/rustdoc-themes",
"src/tools/rustfmt",
"src/tools/suggest-tests",
"src/tools/test-float-parse",
"src/tools/tidy",
"src/tools/tier-check",
"src/tools/unicode-table-generator",
Expand Down
130 changes: 0 additions & 130 deletions compiler/rustc_ast/src/mut_visit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use std::panic;

use rustc_data_structures::flat_map_in_place::FlatMapInPlace;
use rustc_data_structures::stack::ensure_sufficient_stack;
use rustc_span::source_map::Spanned;
use rustc_span::{Ident, Span};
use smallvec::{Array, SmallVec, smallvec};
use thin_vec::ThinVec;
Expand Down Expand Up @@ -499,58 +498,6 @@ fn walk_assoc_item_constraint<T: MutVisitor>(
vis.visit_span(span);
}

pub fn walk_ty<T: MutVisitor>(vis: &mut T, ty: &mut Ty) {
let Ty { id, kind, span, tokens: _ } = ty;
vis.visit_id(id);
match kind {
TyKind::Err(_guar) => {}
TyKind::Infer | TyKind::ImplicitSelf | TyKind::Dummy | TyKind::Never | TyKind::CVarArgs => {
}
TyKind::Slice(ty) => vis.visit_ty(ty),
TyKind::Ptr(MutTy { ty, mutbl: _ }) => vis.visit_ty(ty),
TyKind::Ref(lt, MutTy { ty, mutbl: _ }) | TyKind::PinnedRef(lt, MutTy { ty, mutbl: _ }) => {
visit_opt(lt, |lt| vis.visit_lifetime(lt));
vis.visit_ty(ty);
}
TyKind::BareFn(bft) => {
let BareFnTy { safety, ext: _, generic_params, decl, decl_span } = bft.deref_mut();
visit_safety(vis, safety);
generic_params.flat_map_in_place(|param| vis.flat_map_generic_param(param));
vis.visit_fn_decl(decl);
vis.visit_span(decl_span);
}
TyKind::UnsafeBinder(binder) => {
let UnsafeBinderTy { generic_params, inner_ty } = binder.deref_mut();
generic_params.flat_map_in_place(|param| vis.flat_map_generic_param(param));
vis.visit_ty(inner_ty);
}
TyKind::Tup(tys) => visit_thin_vec(tys, |ty| vis.visit_ty(ty)),
TyKind::Paren(ty) => vis.visit_ty(ty),
TyKind::Pat(ty, pat) => {
vis.visit_ty(ty);
vis.visit_ty_pat(pat);
}
TyKind::Path(qself, path) => {
vis.visit_qself(qself);
vis.visit_path(path);
}
TyKind::Array(ty, length) => {
vis.visit_ty(ty);
vis.visit_anon_const(length);
}
TyKind::Typeof(expr) => vis.visit_anon_const(expr),
TyKind::TraitObject(bounds, _syntax) => {
visit_vec(bounds, |bound| vis.visit_param_bound(bound, BoundKind::TraitObject))
}
TyKind::ImplTrait(id, bounds) => {
vis.visit_id(id);
visit_vec(bounds, |bound| vis.visit_param_bound(bound, BoundKind::Impl));
}
TyKind::MacCall(mac) => vis.visit_mac_call(mac),
}
vis.visit_span(span);
}

pub fn walk_ty_pat<T: MutVisitor>(vis: &mut T, ty: &mut TyPat) {
let TyPat { id, kind, span, tokens: _ } = ty;
vis.visit_id(id);
Expand Down Expand Up @@ -588,13 +535,6 @@ fn walk_ident<T: MutVisitor>(vis: &mut T, Ident { name: _, span }: &mut Ident) {
vis.visit_span(span);
}

fn walk_path_segment<T: MutVisitor>(vis: &mut T, segment: &mut PathSegment) {
let PathSegment { ident, id, args } = segment;
vis.visit_id(id);
vis.visit_ident(ident);
visit_opt(args, |args| vis.visit_generic_args(args));
}

fn walk_path<T: MutVisitor>(vis: &mut T, Path { segments, span, tokens: _ }: &mut Path) {
for segment in segments {
vis.visit_path_segment(segment);
Expand Down Expand Up @@ -729,18 +669,6 @@ fn walk_closure_binder<T: MutVisitor>(vis: &mut T, binder: &mut ClosureBinder) {
}
}

fn walk_coroutine_kind<T: MutVisitor>(vis: &mut T, coroutine_kind: &mut CoroutineKind) {
match coroutine_kind {
CoroutineKind::Async { span, closure_id, return_impl_trait_id }
| CoroutineKind::Gen { span, closure_id, return_impl_trait_id }
| CoroutineKind::AsyncGen { span, closure_id, return_impl_trait_id } => {
vis.visit_id(closure_id);
vis.visit_id(return_impl_trait_id);
vis.visit_span(span);
}
}
}

fn walk_fn<T: MutVisitor>(vis: &mut T, kind: FnKind<'_>) {
match kind {
FnKind::Fn(
Expand Down Expand Up @@ -991,13 +919,6 @@ pub fn walk_flat_map_expr_field<T: MutVisitor>(
smallvec![f]
}

pub fn walk_block<T: MutVisitor>(vis: &mut T, block: &mut Block) {
let Block { id, stmts, rules: _, span, tokens: _ } = block;
vis.visit_id(id);
stmts.flat_map_in_place(|stmt| vis.flat_map_stmt(stmt));
vis.visit_span(span);
}

pub fn walk_item_kind<K: WalkItemKind>(
kind: &mut K,
span: Span,
Expand Down Expand Up @@ -1041,57 +962,6 @@ pub fn walk_flat_map_assoc_item(
smallvec![item]
}

pub fn walk_pat<T: MutVisitor>(vis: &mut T, pat: &mut Pat) {
let Pat { id, kind, span, tokens: _ } = pat;
vis.visit_id(id);
match kind {
PatKind::Err(_guar) => {}
PatKind::Missing | PatKind::Wild | PatKind::Rest | PatKind::Never => {}
PatKind::Ident(_binding_mode, ident, sub) => {
vis.visit_ident(ident);
visit_opt(sub, |sub| vis.visit_pat(sub));
}
PatKind::Expr(e) => vis.visit_expr(e),
PatKind::TupleStruct(qself, path, elems) => {
vis.visit_qself(qself);
vis.visit_path(path);
visit_thin_vec(elems, |elem| vis.visit_pat(elem));
}
PatKind::Path(qself, path) => {
vis.visit_qself(qself);
vis.visit_path(path);
}
PatKind::Struct(qself, path, fields, _etc) => {
vis.visit_qself(qself);
vis.visit_path(path);
fields.flat_map_in_place(|field| vis.flat_map_pat_field(field));
}
PatKind::Box(inner) => vis.visit_pat(inner),
PatKind::Deref(inner) => vis.visit_pat(inner),
PatKind::Ref(inner, _mutbl) => vis.visit_pat(inner),
PatKind::Range(e1, e2, Spanned { span: _, node: _ }) => {
visit_opt(e1, |e| vis.visit_expr(e));
visit_opt(e2, |e| vis.visit_expr(e));
vis.visit_span(span);
}
PatKind::Guard(p, e) => {
vis.visit_pat(p);
vis.visit_expr(e);
}
PatKind::Tuple(elems) | PatKind::Slice(elems) | PatKind::Or(elems) => {
visit_thin_vec(elems, |elem| vis.visit_pat(elem))
}
PatKind::Paren(inner) => vis.visit_pat(inner),
PatKind::MacCall(mac) => vis.visit_mac_call(mac),
}
vis.visit_span(span);
}

fn walk_anon_const<T: MutVisitor>(vis: &mut T, AnonConst { id, value }: &mut AnonConst) {
vis.visit_id(id);
vis.visit_expr(value);
}

fn walk_inline_asm<T: MutVisitor>(vis: &mut T, asm: &mut InlineAsm) {
// FIXME: Visit spans inside all this currently ignored stuff.
let InlineAsm {
Expand Down
Loading
Loading