Rollup of 10 pull requests #142795

Kobzol · 2025-06-20T18:03:26Z

Successful merges:

Add config builder for bootstrap tests #142629 (Add config builder for bootstrap tests)
correct template for #[align] attribute #142715 (correct template for #[align] attribute)
De-dup common code from ExternalCrate methods #142720 (De-dup common code from ExternalCrate methods)
add issue template for rustdoc #142736 (add issue template for rustdoc)
rustc-dev-guide subtree update #142743 (rustc-dev-guide subtree update)
Add a mailmap entry for y21 #142744 (Add a mailmap entry for y21)
Make sure to rebuild rustdoc if src/rustdoc-json-types is changed #142758 (Make sure to rebuild rustdoc if src/rustdoc-json-types is changed)
Convert ilog(10) to ilog10() #142764 (Convert ilog(10) to ilog10())
Some symbol and PathRoot cleanups #142767 (Some symbol and PathRoot cleanups)
remove equivalent new method on context #142769 (remove equivalent new method on context)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Signed-off-by: xizheyin <[email protected]>

…e-case use consistent title capitalization

Adjust some doc for Query System

content has moved to another chapter

use sentence case

Query cleaning

Use stage 1 for building docs

Also replaced '→' symbol with '->' for consistency across the table.

Remove hanging parenthesis from example signature.

Profiling with perf: specify the section of bootstrap settings.

Document Ambig vs Unambig Type/Consts

That was intended to be a list. Also, the order is not relevant.

fix markup

initial instructions for gpu offload

…ingjubilee Convert `ilog(10)` to `ilog10()` Except in tests, convert `integer.ilog(10)` to `integer.ilog10()` for better speed and to provide better examples of code that efficiently counts decimal digits. I couldn't find any instances of `integer.ilog(2)`.

…rochenkov Some symbol and PathRoot cleanups I'm looking into unifying how we join and print paths. Here are some preliminary cleanups. r? ``@petrochenkov``

…thod, r=tgross35 remove equivalent new method on context Noticed the two had converged so much they literally became equivalent. So one could go hehe

Kobzol · 2025-06-20T18:03:32Z

@bors r+ rollup=never p=5

bors · 2025-06-20T18:03:34Z

📌 Commit e7cc4ec has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-06-20T20:01:47Z

⌛ Testing commit e7cc4ec with merge 5526a2f...

bors · 2025-06-20T22:56:29Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 5526a2f to master...

rust-timer · 2025-06-20T22:59:19Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142629	Add config builder for bootstrap tests	`346fa9bdbe558f9668a5e1899de670e326d27640` (link)
#142715	correct template for `#[align]` attribute	`af58c9bedea4ec9daa9372f303dcd27d65c0f5b4` (link)
#142720	De-dup common code from `ExternalCrate` methods	`1eaa0b0cd26e1831ba2dd371670c997d10ce326a` (link)
#142736	add issue template for rustdoc	`02da6e996a11945bc974623a99e038e19baca6fb` (link)
#142743	rustc-dev-guide subtree update	`43e3a0c742087ec0b957f1583ed813321767719b` (link)
#142744	Add a mailmap entry for y21	`6afe32efa7c9ebe4c5a661c79cfc68f05fb7e829` (link)
#142758	Make sure to rebuild rustdoc if `src/rustdoc-json-types` is…	`fac1beb8363f66df4d241acceca59492f03be285` (link)
#142764	Convert `ilog(10)` to `ilog10()`	`886e8711fc5c0fbf6f4b7810da9a656008164395` (link)
#142767	Some symbol and PathRoot cleanups	`b94bfe4e8f6278cc4784bdc9020732d2962cdb40` (link)
#142769	remove equivalent new method on context	`2e2d941547cc41e942598974c180f9de40856050` (link)

previous master: 9c4ff566ba

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-20T22:59:30Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9c4ff56 (parent) -> 5526a2f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5526a2f47cd676ceeedc08cf71ae75ce2e9284ae --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 9805.2s -> 7780.5s (-20.6%)
dist-apple-various: 7948.7s -> 6674.5s (-16.0%)
mingw-check-1: 1817.4s -> 1573.0s (-13.4%)
i686-gnu-2: 6143.2s -> 5339.8s (-13.1%)
dist-aarch64-apple: 6854.4s -> 6044.5s (-11.8%)
aarch64-gnu-debug: 3871.6s -> 3447.4s (-11.0%)
x86_64-gnu-debug: 5954.9s -> 5307.6s (-10.9%)
aarch64-apple: 5114.6s -> 4574.6s (-10.6%)
x86_64-gnu-tools: 3636.1s -> 3267.5s (-10.1%)
x86_64-gnu-llvm-20-2: 6070.5s -> 5467.7s (-9.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-21T03:47:01Z

Finished benchmarking commit (5526a2f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.3%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-5.5%, -4.3%]	2
All ❌✅ (primary)	3.3%	[3.3%, 3.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.606s -> 692.994s (0.06%)
Artifact size: 372.01 MiB -> 371.93 MiB (-0.02%)

tshepang and others added 30 commits June 2, 2025 12:35

use consistent title capitalization

9aa572d

Adjust some doc for Query System

a4c8ef9

Signed-off-by: xizheyin <[email protected]>

Merge pull request rust-lang#2441 from rust-lang/tshepang-remove-titl…

94d56d1

…e-case use consistent title capitalization

Merge pull request rust-lang#2465 from xizheyin/rustc-query

9265493

Adjust some doc for Query System

content has moved to another chapter

a70deb6

Merge pull request rust-lang#2466 from rust-lang/tshepang-moved

9926215

content has moved to another chapter

use sentence case

0834e48

Merge pull request rust-lang#2467 from rust-lang/tshepang-patch-1

a3f261c

use sentence case

title case

820e88a

do not inline links

21a1e51

Merge pull request rust-lang#2468 from rust-lang/query-cleaning

d16e1a1

Query cleaning

Use stage 1 for building docs

808d16c

Merge pull request rust-lang#2471 from Darksonn/patch-1

3edb332

Use stage 1 for building docs

Remove hanging parenthesis from example signature.

1dbf86a

Also replaced '→' symbol with '->' for consistency across the table.

Merge pull request rust-lang#2472 from cbloodsworth/fix/tytable_parens

02334e1

Remove hanging parenthesis from example signature.

Profiling with perf: specify the section of bootstrap settings.

8bc55da

Merge pull request rust-lang#2475 from lolbinarycat/patch-3

671817f

Profiling with perf: specify the section of bootstrap settings.

Stub chapter and consolidate under /hir/

d96b2d4

Write chapter on Unambig vs Ambig Types/Consts

42888bb

Add links

c1506c0

Reviews

39e9800

Merge pull request rust-lang#2474 from BoxyUwU/ambig_unambig_ty_consts

6c7830e

Document Ambig vs Unambig Type/Consts

fix markup

4145596

That was intended to be a list. Also, the order is not relevant.

Merge pull request rust-lang#2476 from rust-lang/tshepang-patch-1

79652d9

fix markup

initial instructions for gpu offload

0a185e4

Merge pull request rust-lang#2447 from rust-lang/offload-docs

f25cfe8

initial instructions for gpu offload

Preparing for merge from rustc

48b36ee

Merge from rustc

d854d56

Add get_host_target function

8c28161

Normalize host target in snapshot tests

21d21d5

Kobzol added 3 commits June 20, 2025 20:03

Rollup merge of rust-lang#142767 - nnethercote:symbol-cleanups, r=pet…

31663db

…rochenkov Some symbol and PathRoot cleanups I'm looking into unifying how we join and print paths. Here are some preliminary cleanups. r? ``@petrochenkov``

Rollup merge of rust-lang#142769 - jdonszelmann:remove-useless-new-me…

e7cc4ec

…thod, r=tgross35 remove equivalent new method on context Noticed the two had converged so much they literally became equivalent. So one could go hehe

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jun 20, 2025

rustbot added the rollup A PR which is a rollup label Jun 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 20, 2025

bors merged commit 5526a2f into rust-lang:master Jun 20, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 20, 2025

Kobzol deleted the rollup-vvnnjno branch June 21, 2025 06:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #142795

Rollup of 10 pull requests #142795

Kobzol commented Jun 20, 2025 •

edited by rustbot

Loading

Uh oh!

Kobzol commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

rust-timer commented Jun 21, 2025

Uh oh!

Uh oh!

Rollup of 10 pull requests #142795

Rollup of 10 pull requests #142795

Conversation

Kobzol commented Jun 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 21, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Kobzol commented Jun 20, 2025 •

edited by rustbot

Loading