-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix x clean
with a fifo
#143288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x clean
with a fifo
#143288
Conversation
`x clean` was failing when it encountered a special file like a fifo because it thought it was a directory.
rustbot has assigned @Mark-Simulacrum. Use |
@bors r+ rollup |
Isn't this reverting efd6eab? |
@bors r- Can you say more about what seems to be reverted? Just from a quick glance, it looks like this still does not follow symlinks. |
Sorry, I was just trying to understand why the original PR was written that way. I thought it was trying to handle a symlink special case on Windows (where |
I kinda wonder if this implementation can be replaced with (This PR itself is fine I think) |
Ok, I'll go ahead and move this forward. @bors r=Kobzol |
Rollup of 11 pull requests Successful merges: - #142749 (Add methods for converting bool to `Result<(), E>`) - #143288 (Fix `x clean` with a fifo) - #143307 (Fast path nitpicks) - #143346 (update coherence example) - #143356 (use unsigned_abs instead of `abs` on signed int to silence clippy) - #143370 (remove redundant #[must_use]) - #143378 (simplify receivers for some array method calls) - #143380 (Replace kw_span by full span for generic const parameters.) - #143381 (rustdoc: don't treat methods under const impls or traits as const) - #143394 (compiler: Document and reduce `fn provide`s in hir crates) - #143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #143288 - ehuss:fix-clean-fifo, r=Kobzol Fix `x clean` with a fifo `x clean` was failing when it encountered a special file like a fifo because it thought it was a directory.
Rollup of 11 pull requests Successful merges: - rust-lang/rust#142749 (Add methods for converting bool to `Result<(), E>`) - rust-lang/rust#143288 (Fix `x clean` with a fifo) - rust-lang/rust#143307 (Fast path nitpicks) - rust-lang/rust#143346 (update coherence example) - rust-lang/rust#143356 (use unsigned_abs instead of `abs` on signed int to silence clippy) - rust-lang/rust#143370 (remove redundant #[must_use]) - rust-lang/rust#143378 (simplify receivers for some array method calls) - rust-lang/rust#143380 (Replace kw_span by full span for generic const parameters.) - rust-lang/rust#143381 (rustdoc: don't treat methods under const impls or traits as const) - rust-lang/rust#143394 (compiler: Document and reduce `fn provide`s in hir crates) - rust-lang/rust#143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`) r? `@ghost` `@rustbot` modify labels: rollup
x clean
was failing when it encountered a special file like a fifo because it thought it was a directory.