Skip to content

rustdoc: don't treat methods under const impls or traits as const #143381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

rustdoc: don't treat methods under const impls or traits as const #143381

merged 1 commit into from
Jul 4, 2025

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 3, 2025 •
edited by rustbot
Loading

Fixes #143071

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 3, 2025
GuillaumeGomez
GuillaumeGomez reviewed Jul 3, 2025
View reviewed changes
src/librustdoc/clean/types.rs
@@ -647,7 +647,20 @@ impl Item {
) -> hir::FnHeader {
let sig = tcx.fn_sig(def_id).skip_binder();
let constness = if tcx.is_const_fn(def_id) {
hir::Constness::Const
// rustc's `is_const_fn` returns `true` for associated functions that have an `impl const` parent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code comment is very appreciated, thanks!

@GuillaumeGomez
Copy link
Member

Thanks!

r=me once CI pass.

@fmease
Copy link
Member

fmease commented Jul 3, 2025

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Jul 3, 2025

📌 Commit 510e5d7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@jhpratt jhpratt mentioned this pull request Jul 4, 2025
Merged
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143407 - jhpratt:rollup-ekkoubw, r=jhpratt
c96a690 
Rollup of 11 pull requests

Successful merges:

 - #142749 (Add methods for converting bool to `Result<(), E>`)
 - #143288 (Fix `x clean` with a fifo)
 - #143307 (Fast path nitpicks)
 - #143346 (update coherence example)
 - #143356 (use unsigned_abs instead of `abs` on signed int to silence clippy)
 - #143370 (remove redundant #[must_use])
 - #143378 (simplify receivers for some array method calls)
 - #143380 (Replace kw_span by full span for generic const parameters.)
 - #143381 (rustdoc: don't treat methods under const impls or traits as const)
 - #143394 (compiler: Document and reduce `fn provide`s in hir crates)
 - #143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01fe1c0 into rust-lang:master Jul 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 4, 2025
rust-timer added a commit that referenced this pull request Jul 4, 2025
@rust-timer
Unrolled build for #143381
8932b94 
Rollup merge of #143381 - fee1-dead-contrib:push-pzxuvlnymxpu, r=GuillaumeGomez

rustdoc: don't treat methods under const impls or traits as const

Fixes #143071
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143407 - jhpratt:rollup-ekkoubw, r=jhpratt
7b9552d 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#142749 (Add methods for converting bool to `Result<(), E>`)
 - rust-lang/rust#143288 (Fix `x clean` with a fifo)
 - rust-lang/rust#143307 (Fast path nitpicks)
 - rust-lang/rust#143346 (update coherence example)
 - rust-lang/rust#143356 (use unsigned_abs instead of `abs` on signed int to silence clippy)
 - rust-lang/rust#143370 (remove redundant #[must_use])
 - rust-lang/rust#143378 (simplify receivers for some array method calls)
 - rust-lang/rust#143380 (Replace kw_span by full span for generic const parameters.)
 - rust-lang/rust#143381 (rustdoc: don't treat methods under const impls or traits as const)
 - rust-lang/rust#143394 (compiler: Document and reduce `fn provide`s in hir crates)
 - rust-lang/rust#143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`)

r? `@ghost`
`@rustbot` modify labels: rollup
@fee1-dead fee1-dead deleted the push-pzxuvlnymxpu branch July 5, 2025 11:49
@Noratrieb Noratrieb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 30, 2025
@Noratrieb
Copy link
Member

nominating this for beta backport as this leads to misleading documentation. there was a duplicate reported #143375 and I've just now seen someone being confused by this being wrong on stable

@fmease
Copy link
Member

fmease commented Jul 31, 2025

Beta backport accepted as per #t-rustdoc > beta-nominated: #143381 @ 💬.

@fmease fmease added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 31, 2025
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 1, 2025
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.90.0, 1.89.0 Aug 1, 2025
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 1, 2025
Merged
bors added a commit that referenced this pull request Aug 2, 2025
@bors
Auto merge of #144800 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
4a18378 
[beta] backports

Backport:

*  add unsupported_calling_conventions to lint list #144772
*  thread name in stack overflow message #144500
*  rustdoc: don't treat methods under const impls or traits as const #143381
* [beta] Clippy beta backport #144742

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

std docs incorrectly renders trait methods as const
7 participants
@fee1-dead @rustbot @GuillaumeGomez @fmease @bors @Noratrieb @Mark-Simulacrum