-
Notifications
You must be signed in to change notification settings - Fork 79
ci: Don't set compiler-builtins-no-f16-f128
#743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@FractalFir: Is this the error you got on Dec Alpha or something: https://github.com/rust-lang/rustc_codegen_gcc/actions/runs/16532424105/job/46760590729?pr=743#step:11:64 ? |
Yeah, that's the same error. Looks like GCC is reporting it supports f128 on m68k when it actually doesn't? |
Actually, I think the toolchain here is from before rust-lang/rust#143405 merged, meaning rust-lang/rust@be35d37 isn't available. Should have known since that is what we were looking at in #t-compiler/help > How to correctly disable `f16` and `f128` when bootstraping. |
e52a112
to
6a7ae71
Compare
Looks like this is getting stuck because running Started discussion at #t-cargo > Detecting `-Zcodegen-backend` from build.rs. |
b505ad1
to
4265f3b
Compare
This is in the compiler-builtins repository but has yet to be synced to rust-lang/rust and then rustc_codegen_gcc. Once that happens, this patch can be removed (it will no longer apply). Link: rust-lang/compiler-builtins@87a66ec
Since rust-lang/rust be35d37d8b6c ("Use the compiler to determine whether or not to enable f16 and f128"), `compiler-builtins` relies on `rustc` to report whether or not `f16` and `f128` are supported, which is reported by the backend. This means that there should no longer be any need to set this config in CI. Backend config: https://github.com/rust-lang/rustc_codegen_gcc/blob/f682d09eefc6700b9e5851ef193847959acf4fac/src/lib.rs#L499-L510
4265f3b
to
fe6f5ef
Compare
🎉 it works! The first commit is rust-lang/compiler-builtins@87a66ec. It's in the compiler-builtins repo now but will take a while to sync to rust-lang/rust then rust-lang/rustc_codegen_gcc, so using a patch unblocks this. |
Since rust-lang/rust be35d37d8b6c ("Use the compiler to determine whether or not to enable f16 and f128"),
compiler-builtins
relies onrustc
to report whether or notf16
andf128
are supported, which is reported by the backend. This means that there should no longer be any need to set this config in CI.Backend config:
rustc_codegen_gcc/src/lib.rs
Lines 499 to 510 in f682d09