Incorrect indentation when using return in a macro

[stevenroose]

This macros is formatted using rustfmt:

macro_rules! m {
	($a:expr) => {
		if $a {
			return;
			}
	};
}

That closing curly bracket under the return clearly has to be one indented one level less.

Config used:

hard_tabs = true
use_small_heuristics = "Off"

[calebcartwright]

I can reproduce this one with the latest rustfmt version, but only when hard_tabs is set to true

[stevenroose]

Seriously? That's not a good sign.. I would expect rustfmt internally to just specify levels of indentation and afterwards convert that into actual tabs/spaces. Does rustfmt have an option to specify the number of spaces for one level of indentation?

[calebcartwright]

Does rustfmt have an option to specify the number of spaces for one level of indentation

https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#tab_spaces

[ayazhafiz]

This was fixed by 2836f9b

[calebcartwright]

Thanks for confirming @ayazhafiz! Would you be willing to open a PR with a corresponding test case to cover this (and the other relevant issues you noted were fixed by that commit)?

It's always super helpful for us to have test cases for past issues to prevent regressions

[ayazhafiz]

For sure. I'll do this in the next day or two.

…

On Mon, May 18, 2020 at 8:27 PM Caleb Cartwright ***@***.***> wrote: Thanks for confirming @ayazhafiz <https://github.com/ayazhafiz>! Would you be willing to open a PR with a corresponding test case to cover this (and the other relevant issues you noted were fixed by that commit)? It's always super helpful for us to have test cases for past issues to prevent regressions — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3936 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6GL6R6G3IT3BLWUB4BM7DRSH4CLANCNFSM4JQGACQQ> .