Add test cases for fixed issues #4189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .long() | ||
| .long() | ||
| .long(), | ||
| ); |
There was a problem hiding this comment.
What's this second one validating that's not covered by the first one?
There was a problem hiding this comment.
The first is a function, the second is the assert! macro. Per #3550 we want to see that assert! is formatted similar to regular function calls.
There was a problem hiding this comment.
ha! and that's why reviewing PRs when half asleep isn't a great idea 😄
The cases with `hard_tabs: true` were fixed in 2836f9b. Not sure about the rest, but this suggests a number of open issues are already resolved. Closes rust-lang#3608 Closes rust-lang#3550 Closes rust-lang#3638 Closes rust-lang#3858 Closes rust-lang#3936
topecongiro
approved these changes
May 21, 2020
bradleypmartin
pushed a commit
to bradleypmartin/rustfmt
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cases with
hard_tabs: truewere fixed in 2836f9b.Not sure about the rest, but this suggests a number of open issues are
already resolved.
Closes #3068
Closes #3550
Closes #3638
Closes #3858
Closes #3936