Skip to content

increase the timeout for running rustc --version #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Dec 15, 2017

Fixes #1312

@knight42
Copy link
Contributor

knight42 commented Jan 5, 2018

I encounter this problem occasionally on my machine as well and I think it's safe to merge this PR.

@alexcrichton
Copy link
Member

I'm sort of wary to merge this, what's causing rustc to take 10 seconds to prints its version?

@petrochenkov
Copy link
Contributor

what's causing rustc to take 10 seconds to prints its version?

Guess: the toolchain is on a drive that's currently in low-power/low-noise mode and some wake up time is needed before rustc can be launched.

@Diggsey
Copy link
Contributor

Diggsey commented Jan 5, 2018

Couple of ideas:

  • Make the time-out configurable, and if any binaries time-out, print a help message at the bottom explaining how to adjust the time-out.

  • Try reading from the executable file before loading it, so we're not including the time taken to possibly spin up a drive.

@knight42
Copy link
Contributor

knight42 commented Jan 6, 2018

@alexcrichton 10 secs may be too long, but 3 secs can be too short in some cases, like after a reboot:

>>> time rustc --version
rustc 1.24.0-nightly (b98fd524e 2018-01-05)
rustc --version  0.21s user 0.07s system 3% cpu 7.161 total
>>> time rustc --version
rustc 1.24.0-nightly (b98fd524e 2018-01-05)
rustc --version  0.18s user 0.03s system 99% cpu 0.208 total

@alexcrichton
Copy link
Member

@bors: r+

Ok!

@bors
Copy link
Contributor

bors commented Jan 8, 2018

📌 Commit 09a23b7 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 8, 2018

⌛ Testing commit 09a23b7 with merge 5e60067...

bors added a commit that referenced this pull request Jan 8, 2018
increase the timeout for running `rustc --version`

Fixes #1312
@bors
Copy link
Contributor

bors commented Jan 9, 2018

💥 Test timed out

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Jan 9, 2018

⌛ Testing commit 09a23b7 with merge fe1592b...

bors added a commit that referenced this pull request Jan 9, 2018
increase the timeout for running `rustc --version`

Fixes #1312
@bors
Copy link
Contributor

bors commented Jan 9, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 9, 2018 via email

@bors
Copy link
Contributor

bors commented Jan 9, 2018

⌛ Testing commit 09a23b7 with merge f2bd051...

bors added a commit that referenced this pull request Jan 9, 2018
increase the timeout for running `rustc --version`

Fixes #1312
@bors
Copy link
Contributor

bors commented Jan 9, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 10, 2018 via email

@bors
Copy link
Contributor

bors commented Jan 10, 2018

⌛ Testing commit 09a23b7 with merge 38e1d3a...

bors added a commit that referenced this pull request Jan 10, 2018
increase the timeout for running `rustc --version`

Fixes #1312
@bors
Copy link
Contributor

bors commented Jan 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 38e1d3a to master...

@bors bors merged commit 09a23b7 into rust-lang:master Jan 10, 2018
@bors bors mentioned this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants