Workspaces #1330
Closed
Workspaces #1330
+245
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I think that test might fail anyway for me |
|
@bors: r+ 👍 |
|
📌 Commit cc043f3 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 5, 2018
Workspaces This is mostly moving files around and adjusting paths in response. The idea is for Rustup to have a 'standard' workspaces layout, rather than the weird mix of one workspace plus a bunch of non-workspace crates. It is failing a test locally (`uninstall_self_delete_works`), so I thought I'd get some extra eyes on it. It needs some high-level docs about how to build/test before it is ready to land. r? @alexcrichton @Diggsey
|
💔 Test failed - status-appveyor |
|
|
I think |
|
☔ The latest upstream changes (presumably #1313) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #1354) made this pull request unmergeable. Please resolve the merge conflicts. |
|
CLsoing since I haven't had time to rebase and it is now way out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly moving files around and adjusting paths in response. The idea is for Rustup to have a 'standard' workspaces layout, rather than the weird mix of one workspace plus a bunch of non-workspace crates.
It is failing a test locally (
uninstall_self_delete_works), so I thought I'd get some extra eyes on it. It needs some high-level docs about how to build/test before it is ready to land.r? @alexcrichton @Diggsey