Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

add the bare and separator-only variants of addString to Iterator #457

Merged
merged 2 commits into from
Feb 24, 2018
Merged

add the bare and separator-only variants of addString to Iterator #457

merged 2 commits into from
Feb 24, 2018

Conversation

tim-ruhland
Copy link
Contributor

addresses #401

@tim-ruhland
Copy link
Contributor Author

Since this is my first pull request, I am confirming that I have signed Scala CLA.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of using default parameter values instead of overloading?

@tim-ruhland
Copy link
Contributor Author

tim-ruhland commented Feb 19, 2018

Keeping the overloaded functions may be better than default parameter values because using default parameters would change the usage for second variant from addString(b, sep) to addString(b, "", sep) and that would not be preferable. Also, the overloaded methods follow the mkString variants, and whatever approach is decided should be applied to both.

@julienrf
Copy link
Contributor

Thanks, can you rebase your work and fix conflicts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants