Introduce IterableOnceOps as common abstraction for Iterable & Iterator #480
Conversation
|
Looks like an actual unsoundness in |
- Unlike the other Ops types, IterableOnceOps is *not* implemented by IterableOnce but only by Iterator and Iterable. - Fix the hierarchy of MultiSets and SortedMultiSets: The refactoring caused soundness problems to show up that were not reported before. These types now follow the usual diamond pattern where mutable/immutable extends generic and sorted extends unsorted.
szeiger
force-pushed
the
wip/iterableonceops
branch
from
60c1065 to
4b21b76
Compare
|
Rebased on top of #457 |
| with MultiSetOps[A, MultiSet, MultiSet[A]] { | ||
|
|
||
| override def iterableFactory: IterableFactory[MultiSet] = MultiSet | ||
| } |
There was a problem hiding this comment.
Can you elaborate on the problem that is solved by introducing the separation MultiSet/MultiSetImpl?
There was a problem hiding this comment.
Oh maybe that’s for making SortedMultiSet a subtype of MultiSet?
There was a problem hiding this comment.
Yes, you want the usual diamond pattern with all of:
-
mutable.SortedMultiSet <: collection.SortedMultiSet
-
immutable.SortedMultiSet <: collection.SortedMultiSet
-
mutable.MultiSet <: collection.MultiSet
-
immutable.MultiSet <: collection.MultiSet
-
collection.SortedMultiSet <: collection.MultiSet
-
mutable.SortedMultiSet <: mutable.MultiSet
-
immutable.SortedMultiSet <: immutable.MultiSet
This requires that MultiSet is a trait.
| /** This implementation trait can be mixed into an `IterableOnce` to get the basic methods that are shared between | ||
| * `Iterator` and `Iterable`. The `IterableOnce` must support multiple calls to `iterator()` but may or may not | ||
| * return the same `Iterator` every time. | ||
| */ |
There was a problem hiding this comment.
You should define the documentation variables that are not inherited but used in the operations’ scaladoc.
Fixes #465