Skip to content

re-add Play to 2.12.x community build for 2.12.0-RC1 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Sep 1, 2016 · 6 comments · Fixed by #299
Closed

re-add Play to 2.12.x community build for 2.12.0-RC1 #272

SethTisue opened this issue Sep 1, 2016 · 6 comments · Fixed by #299
Assignees

Comments

@SethTisue
Copy link
Member

references:

@SethTisue
Copy link
Member Author

SethTisue commented Sep 2, 2016

excluding Play-Streams subproject until akka-stream is added

@SethTisue
Copy link
Member Author

SethTisue commented Sep 2, 2016

play-twirl re-added: #273; twirl changes submitted upstream: playframework/twirl#118

@schmitch
Copy link
Contributor

schmitch commented Sep 4, 2016

Actually Play (even core is dependent from akka-stream). Also play, needs play-doc to work against RC1 first (but that shouldn't be a problem I guess, 2.12.0-M5 worked).

@schmitch
Copy link
Contributor

schmitch commented Sep 14, 2016

I updated playframework/playframework#6432 to try to build against Scala 2.12.0-RC1 however these are the things I run into when running the tests:

[error] key not found: value userForm$1
java.util.NoSuchElementException: key not found: value userForm$1
    at scala.collection.MapLike.default(MapLike.scala:232)
    at scala.collection.mutable.HashMap.apply(HashMap.scala:65)

Looks like: scala/scala#5395


Then I've run into:

[error] /Users/schmitch/projects/schmitch/play/playframework/framework/src/play-integration-test/src/test/scala/play/it/mvc/FiltersSpec.scala:249: type mismatch;
[error]  found   : scala.concurrent.ExecutionContext
[error]  required: java.util.concurrent.Executor
[error]           }, ec)

Which happens cause the Implicits.global is no more a ExecutionContextProvider and gets down casted to ExecutionContext.
https://issues.scala-lang.org/browse/SI-8849


And the rest is probably SAM Types, I guess, only some times?
scala/scala#5307

So for running the whole test suite I need to wait till RC2

@SethTisue
Copy link
Member Author

SethTisue commented Sep 14, 2016

I need to wait till RC2

because Play is so important in the Scala ecosystem, I would hope you would not wait, if it all possible, since waiting delays discovery of further problems, perhaps necessitating RC3, which we should try very hard to avoid

every commit of every PR against scala/scala, even before it is merged, results in a Scala version being published that you can test against, as described in https://github.com/scala/scala/blob/2.12.x/README.md#scala-ci

@SethTisue SethTisue self-assigned this Sep 23, 2016
@SethTisue
Copy link
Member Author

SethTisue commented Sep 23, 2016

Play-Streams can presumably be re-added now that #146 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants