-
Notifications
You must be signed in to change notification settings - Fork 59
re-add Play to 2.12.x community build for 2.12.0-RC1 #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
excluding Play-Streams subproject until akka-stream is added |
play-twirl re-added: #273; twirl changes submitted upstream: playframework/twirl#118 |
Actually Play (even core is dependent from akka-stream). Also play, needs play-doc to work against RC1 first (but that shouldn't be a problem I guess, 2.12.0-M5 worked). |
I updated playframework/playframework#6432 to try to build against Scala 2.12.0-RC1 however these are the things I run into when running the tests:
Looks like: scala/scala#5395 Then I've run into:
Which happens cause the Implicits.global is no more a ExecutionContextProvider and gets down casted to ExecutionContext. And the rest is probably SAM Types, I guess, only some times? So for running the whole test suite I need to wait till RC2 |
because Play is so important in the Scala ecosystem, I would hope you would not wait, if it all possible, since waiting delays discovery of further problems, perhaps necessitating RC3, which we should try very hard to avoid every commit of every PR against scala/scala, even before it is merged, results in a Scala version being published that you can test against, as described in https://github.com/scala/scala/blob/2.12.x/README.md#scala-ci |
Play-Streams can presumably be re-added now that #146 is resolved |
references:
The text was updated successfully, but these errors were encountered: