Skip to content

re-add play2-core #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2016
Merged

Conversation

SethTisue
Copy link
Member

fixes #272

@SethTisue
Copy link
Member Author

SethTisue commented Sep 24, 2016

green locally. let's see what Jenkins thinks https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/628/consoleFull

I specified a newer Scala nightly (2.12.0-6df14e5-nightly) that everything isn't cached for yet, so it'll take a while

@SethTisue
Copy link
Member Author

this is kinda janky stuff — we're using a commit from my wip branch in the playframework repo, forked from @schmitch's wip branch — but for Scala 2.12.0 to go forward, it's good enough. let's revisit this in a community build context once all the Play/2.12 issues have been ironed out in the normal Play build

@SethTisue SethTisue self-assigned this Sep 24, 2016
@schmitch
Copy link
Contributor

I actually rebased my PR against master, so If the build succeeds I try to get it included so that we can use the master branch: playframework/playframework#6432

Also be aware that the failed tests were in: Play-WS and Play-Integration-Test and I never run the documentation tests (which also tests stuff that won't happen in the Integration-Tests) against 2.12.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-add Play to 2.12.x community build for 2.12.0-RC1
2 participants