Improve compiler messages #4443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 2, 2018
smarter
approved these changes
May 2, 2018
| @@ -358,6 +350,8 @@ object Checking { | |||
| fail(AbstractOverrideOnlyInTraits(sym)) | |||
| if (sym.is(Trait) && sym.is(Final)) | |||
| fail(TraitsMayNotBeFinal(sym)) | |||
| if (sym.hasAnnotation(defn.TailrecAnnot) && !sym.is(Method | ModuleVal) ) | |||
There was a problem hiding this comment.
Style: write )) instead of ) )
Maybe add a comment: // Skip ModuleVal since the annotation will also be on the ModuleClass
| implicit val ctx: Context = ictx | ||
| assertMessageCount(4, messages) | ||
|
|
||
| val tailRegMessages = messages.map{ case m :TailrecNotApplicable => m.symbolKind}.toSet |
Now the compiler will give compile errors if the annotation is used on other kinds then methods.
ingarabr
force-pushed
the
compiler-messages
branch
from
0628582 to
e063257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1589