Skip to content

disable conditional writes #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

disable conditional writes #1368

merged 2 commits into from
Sep 17, 2025

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Sep 17, 2025 •
edited
Loading

Description:

  • Disables conditional writes in tensorstore

Todos:

  • Updated Changelog

@normanrz normanrz self-assigned this Sep 17, 2025
@normanrz normanrz mentioned this pull request Sep 17, 2025
Open
1 task
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9327 7808 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
webknossos/webknossos/dataset/_array.py 88% 🟢
TOTAL 88% 🟢

updated for commit: bcff8e4 by action🐍

AndreaNathansen
AndreaNathansen approved these changes Sep 17, 2025
View reviewed changes
Copy link

@AndreaNathansen AndreaNathansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array resizing works now, thanks for fixing!

@normanrz normanrz merged commit 17d9670 into master Sep 17, 2025
26 checks passed
@normanrz normanrz deleted the no-cond-write branch September 17, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaNathansen AndreaNathansen AndreaNathansen approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @AndreaNathansen