Skip to content

disable conditional writes #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

disable conditional writes #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5d8afc
disable conditional writes
normanrz Sep 17, 2025
bcff8e4
changelog
normanrz Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions webknossos/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
### Added

### Changed
- Disabled conditional writes for S3 buckets in tensorstore. [#1368](https://github.com/scalableminds/webknossos-libs/pull/1368)

### Fixed
- Fixed that some operations that need an authentication token didn’t ask for it but just failed. [#1366](https://github.com/scalableminds/webknossos-libs/pull/1366)
Expand Down
1 change: 1 addition & 0 deletions webknossos/webknossos/dataset/_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ def _make_kvstore(path: UPath) -> str | dict[str, str | list[str]]:
"driver": "s3",
"path": parsed_url.path.lstrip("/"),
"bucket": parsed_url.netloc,
"use_conditional_write": False,
}
if endpoint_url := path.storage_options.get("client_kwargs", {}).get(
"endpoint_url", None
Expand Down
Loading