Skip to content

Fix download #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2018
Merged

Fix download #3547

merged 3 commits into from
Dec 7, 2018

Conversation

jfrohnhofen
Copy link
Contributor

Issues:

  • Needs tracingstore update after deployment
  • Ready for review

@jfrohnhofen jfrohnhofen requested a review from jstriebel December 7, 2018 10:52
jstriebel
jstriebel approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚢

@jstriebel
Copy link
Contributor

Tested and verified with 4 👀 locally.

@jstriebel jstriebel merged commit 882a540 into master Dec 7, 2018
@jstriebel jstriebel deleted the fix-download branch December 7, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jstriebel jstriebel jstriebel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download of small volume tracings produces 0 b data.zip
2 participants
@jfrohnhofen @jstriebel