Skip to content

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Oct 16, 2024

In some datasets / datasource-properties.json files the mags (resolutions) are not sorted correctly. This leads to wk streaming them in this unordered version. This PR ensures that wk streams the mags in ascending sorted order.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Edit your favourites dataset's datasource-properties.json to have unsorted resolutions / mags for at least on layer
  • open the datasource-properties.json via zarr streaming: e.g. localhost:9000/data/zarr3_experimental/sample_organization/l4_sample/
  • check the order in which the mags are listed for the layer with unordered resolutions: e.g. localhost:9000/data/zarr3_experimental/sample_organization/l4_sample/color; They should be sorted now. => that should be the fix.

Compare with broken state via

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review October 16, 2024 13:20
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks! I just added two small comments :)

@MichaelBuessemeyer
Copy link
Contributor Author

Ok thanks for the feedback 🙏 Should be applied now

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MichaelBuessemeyer MichaelBuessemeyer enabled auto-merge (squash) October 17, 2024 15:04
@MichaelBuessemeyer MichaelBuessemeyer merged commit fb9b450 into master Oct 21, 2024
2 checks passed
@MichaelBuessemeyer MichaelBuessemeyer deleted the fix-zarr-streaming-mag-order branch October 21, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix listing mags in correct order in zarr3 streaming

2 participants