-
Notifications
You must be signed in to change notification settings - Fork 29
Support reading Blosc-compressed data chunks with autoshuffle #8387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changelog has been updated to record new features, improvements, bug fixes, and the removal of an existing volume annotation downsampling feature. Notably, support for Blosc AUTOSHUFFLE in compressed dataset reading has been added. Additionally, the BloscCompressor class has been modified to include AUTOSHUFFLE in its supported shuffle types, with corresponding updates to error messaging. The PR also addresses several bugs including issues during tree merges, onboarding display glitches, and segment registration at coarser magnifications, and enhances UI behavior for slider scrolling. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/Compressor.scala (1)
244-244
: Consider improving error message readability.While the error message update correctly includes AUTOSHUFFLE, the formatting could be improved for better readability.
Consider this alternative format:
- List("-1 (AUTOSHUFFLE), 0 (NOSHUFFLE)", "1 (BYTESHUFFLE)", "2 (BITSHUFFLE)") + List( + "-1 (AUTOSHUFFLE)", + "0 (NOSHUFFLE)", + "1 (BYTESHUFFLE)", + "2 (BITSHUFFLE)" + )This would make the error message more readable and maintainable.
Also applies to: 248-248
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.unreleased.md
(1 hunks)webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/Compressor.scala
(2 hunks)
🔇 Additional comments (2)
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/Compressor.scala (1)
201-201
: LGTM! Added AUTOSHUFFLE support.The addition of AUTOSHUFFLE to the supported shuffle types aligns with the PR objectives and enables reading Blosc-compressed data chunks with autoshuffle.
CHANGELOG.unreleased.md (1)
19-19
: LGTM! Clear and well-formatted changelog entry.The changelog entry correctly documents the new feature and follows the project's changelog format.
Turns out the error didn’t come from JBlosc, but our own implementation. @frcroth do you remember if there was a specific reason to originally reject AUTOSHUFFLE?
URL of deployed dev instance (used for testing):
Steps to test:
Issues: